You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/27 03:46:05 UTC
[GitHub] [incubator-nuttx] anchao opened a new pull request #2416: net/tcp: fallback to unthrottle pool to avoid deadlock
anchao opened a new pull request #2416:
URL: https://github.com/apache/incubator-nuttx/pull/2416
## Summary
net/tcp: fallback to unthrottle pool to avoid deadlock
Add a fallback mechanism to ensure that there are still available
iobs for an free connection, Guarantees all connections will have
a minimum threshold iob to keep the connection not be hanged.
Change-Id: I59bed98d135ccd1f16264b9ccacdd1b0d91261de
Signed-off-by: chao.an <an...@xiaomi.com>
## Impact
TCP receive deadlock
## Testing
HTTP streaming
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #2416: net/tcp: fallback to unthrottle pool to avoid deadlock
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #2416:
URL: https://github.com/apache/incubator-nuttx/pull/2416#discussion_r641291040
##########
File path: net/tcp/tcp_recvwindow.c
##########
@@ -164,17 +165,24 @@ uint16_t tcp_get_recvwindow(FAR struct net_driver_s *dev)
recvwndo = (uint16_t)rwnd;
}
+ else if (IOB_QEMPTY(&conn->readahead))
+ {
+ /* Advertise maximum segment size for window edge if here is no
+ * available iobs on current "free" connection.
+ */
+
+ recvwndo = mss;
Review comment:
is it assumed that CONFIG_IOB_THROTTLE is big enough to cover mss * the number of connections?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #2416: net/tcp: fallback to unthrottle pool to avoid deadlock
Posted by GitBox <gi...@apache.org>.
davids5 commented on a change in pull request #2416:
URL: https://github.com/apache/incubator-nuttx/pull/2416#discussion_r641443928
##########
File path: net/tcp/tcp_recvwindow.c
##########
@@ -164,17 +165,24 @@ uint16_t tcp_get_recvwindow(FAR struct net_driver_s *dev)
recvwndo = (uint16_t)rwnd;
}
+ else if (IOB_QEMPTY(&conn->readahead))
+ {
+ /* Advertise maximum segment size for window edge if here is no
Review comment:
-/* Advertise maximum segment size for window edge if here is no
+/* Advertise maximum segment size for window edge if there are no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2416: net/tcp: fallback to unthrottle pool to avoid deadlock
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #2416:
URL: https://github.com/apache/incubator-nuttx/pull/2416
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org