You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Jacopo Cappellato <ja...@gmail.com> on 2008/08/15 17:32:47 UTC
Re: svn commit: r686251 - in /ofbiz/trunk/framework/minilang/src: META-INF/services/ org/ofbiz/minilang/method/conditional/
Adam,
please remember the License header and the svn properties (still
missing from the last new file you added to the repository).
Thanks,
Jacopo
On Aug 15, 2008, at 5:29 PM, doogie@apache.org wrote:
> Author: doogie
> Date: Fri Aug 15 08:29:29 2008
> New Revision: 686251
>
> URL: http://svn.apache.org/viewvc?rev=686251&view=rev
> Log:
> More use of ServiceRegistry.
>
> Added:
> ofbiz/trunk/framework/minilang/src/META-INF/services/
> org.ofbiz.minilang.method.conditional.ConditionalFactory
> Modified:
> ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/
> conditional/CombinedCondition.java
> ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/
> conditional/CompareCondition.java
> ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/
> conditional/CompareFieldCondition.java
> ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/
> conditional/ConditionalFactory.java
> ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/
> conditional/EmptyCondition.java
> ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/
> conditional/HasPermissionCondition.java
> ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/
> conditional/RegexpCondition.java
> ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/
> conditional/ValidateMethodCondition.java
>
> Added: ofbiz/trunk/framework/minilang/src/META-INF/services/
> org.ofbiz.minilang.method.conditional.ConditionalFactory
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/minilang/src/META-INF/services/org.ofbiz.minilang.method.conditional.ConditionalFactory?rev=686251&view=auto
> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> --- ofbiz/trunk/framework/minilang/src/META-INF/services/
> org.ofbiz.minilang.method.conditional.ConditionalFactory (added)
> +++ ofbiz/trunk/framework/minilang/src/META-INF/services/
> org.ofbiz.minilang.method.conditional.ConditionalFactory Fri Aug 15
> 08:29:29 2008
> @@ -0,0 +1,11 @@
> +org.ofbiz.minilang.method.conditional.CombinedCondition
> $OrConditionFactory
> +org.ofbiz.minilang.method.conditional.CombinedCondition
> $XorConditionFactory
> +org.ofbiz.minilang.method.conditional.CombinedCondition
> $AndConditionFactory
> +org.ofbiz.minilang.method.conditional.CombinedCondition
> $NotConditionFactory
> +org.ofbiz.minilang.method.conditional.CompareCondition
> $CompareConditionFactory
> +org.ofbiz.minilang.method.conditional.CompareFieldCondition
> $CompareFieldConditionFactory
> +org.ofbiz.minilang.method.conditional.EmptyCondition
> $EmptyConditionFactory
> +org.ofbiz.minilang.method.conditional.HasPermissionCondition
> $HasPermissionConditionFactory
> +org.ofbiz.minilang.method.conditional.RegexpCondition
> $RegexpConditionFactory
> +org.ofbiz.minilang.method.conditional.ValidateMethodCondition
> $ValidateMethodConditionFactory
> +
>
Re: svn commit: r686251 - in /ofbiz/trunk/framework/minilang/src:
META-INF/services/ org/ofbiz/minilang/method/conditional/
Posted by Adam Heath <do...@brainfood.com>.
Jacopo Cappellato wrote:
> On Aug 15, 2008, at 5:42 PM, Adam Heath wrote:
>
>> Jacopo Cappellato wrote:
>>
>>> please remember the License header and the svn properties (still
>>> missing from the last new file you added to the repository).
>>
>> You're right, I forgot to add it to *this* new file; but I already did
>> it for the last one.
>>
>
> Yeah, I noticed the fix for the license... I was just speaking about the
> svn properities for the old file.
>
> The best thing to do is to load the svn config file in your user home,
> so that the standard svn properties will be automatically added to all
> the new files you commit; you can find a link to our official config
> file (and the simple instructions to use it) here:
Ew. That's bad. I hate that svn and svk don't have per-checkout config
settings.
So, I wrote a program to automate it.
==
mkdir $HOME/bin
PATH=$HOME/bin:$PATH
cp $attachments/svk $HOME/bin/svk
cp $attachments/.svn-props.txt $ofbiz_checkout_root/.svn-props.txt
==
This should also work for svn(by copying the script and naming it svn
instead), but I haven't tested that. I haven't tested it on anything
other than debian linux. The only odd thing is does it call
/bin/readlink, but most systems should already have that.
If others like this script, then we could check in that .svn-props.txt,
and the binary. For now, I'll keep them local.
Re: svn commit: r686251 - in /ofbiz/trunk/framework/minilang/src: META-INF/services/ org/ofbiz/minilang/method/conditional/
Posted by Jacopo Cappellato <ja...@gmail.com>.
On Aug 15, 2008, at 5:42 PM, Adam Heath wrote:
> Jacopo Cappellato wrote:
>
>> please remember the License header and the svn properties (still
>> missing from the last new file you added to the repository).
>
> You're right, I forgot to add it to *this* new file; but I already
> did it for the last one.
>
Yeah, I noticed the fix for the license... I was just speaking about
the svn properities for the old file.
The best thing to do is to load the svn config file in your user home,
so that the standard svn properties will be automatically added to all
the new files you commit; you can find a link to our official config
file (and the simple instructions to use it) here:
http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Source+Repository+and+Access
(see the paragraph "Developer Access").
There is also a mention to this here:
http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices
> What svn properties need to be set? Or, point me at the
> documentation that says what should be done.
For files like these (that are similar to Java source files) we need
the following properties:
svn:mime-type=text/plain
svn:eol-style=native
svn:keywords="Date Rev Author URL Id"
You can manually set them to two files in your local repository using
the "svn propset" command and then committing the file.
For example:
svn propset svn:mime-type text/plain path/to/file/filename
svn propset ....
svn commit path/to/file/filename
Hope it helps,
Jacopo
Re: svn commit: r686251 - in /ofbiz/trunk/framework/minilang/src:
META-INF/services/ org/ofbiz/minilang/method/conditional/
Posted by Adam Heath <do...@brainfood.com>.
Jacopo Cappellato wrote:
> please remember the License header and the svn properties (still missing
> from the last new file you added to the repository).
You're right, I forgot to add it to *this* new file; but I already did
it for the last one.
What svn properties need to be set? Or, point me at the documentation
that says what should be done.