You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/12/16 17:14:29 UTC
[GitHub] [incubator-druid] gianm edited a comment on issue #9029:
GenericIndexedWriter: Fix issue when writing large values to large columns.
gianm edited a comment on issue #9029: GenericIndexedWriter: Fix issue when writing large values to large columns.
URL: https://github.com/apache/incubator-druid/pull/9029#issuecomment-566154772
> so , "anything that changes getSerializedSize(), should be immediately followed by a `if(getSerializedSize() > fileSizeLimit) { .. }` block" .
Or, at least that needs to be between anything that changes the serialized size and anything that depends on it being less than the fileSizeLimit. (Or less than `Integer.MAX_VALUE`)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org