You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by "Sean Busbey (JIRA)" <ji...@apache.org> on 2019/05/06 03:35:00 UTC

[jira] [Commented] (HBASE-22358) Change rubocop configuration for method length

    [ https://issues.apache.org/jira/browse/HBASE-22358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16833511#comment-16833511 ] 

Sean Busbey commented on HBASE-22358:
-------------------------------------

+1 on anything between 50 and 150.

> Change rubocop configuration for method length
> ----------------------------------------------
>
>                 Key: HBASE-22358
>                 URL: https://issues.apache.org/jira/browse/HBASE-22358
>             Project: HBase
>          Issue Type: Improvement
>          Components: community, shell
>            Reporter: Jan Hentschel
>            Assignee: Murtaza Hassan
>            Priority: Minor
>              Labels: beginner, beginners
>
> rubocop currently uses a maximum method length for the Ruby code of 10, which is way too restrictive. In Checkstyle we're using 150 lines per method. Don't know if it needs to be that much, but something between 50 and 75 seems to be more realistic, especially for test cases.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)