[jira] [Commented] (CALCITE-4960) Enable unit tests in Elasticsearch Adapter

["Julian Hyde (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-4960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465067#comment-17465067 ] 

Julian Hyde commented on CALCITE-4960:
--------------------------------------

Thanks to [~VAE] for getting this going. Disabled CI tests are a huge liability. I see that [~zabetak] is reviewing the PR, and trust his judgment.

> Enable unit tests in Elasticsearch Adapter
> ------------------------------------------
>
>                 Key: CALCITE-4960
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4960
>             Project: Calcite
>          Issue Type: Improvement
>          Components: elasticsearch-adapter
>    Affects Versions: 1.28.0
>            Reporter: ZheHu
>            Assignee: ZheHu
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Currently, the following unit test cases are disabled in ES Adapter due to CI failure(see CALCITE-4101):
>  * BooleanLogicTest
>  * ElasticSearchAdapterTest
>  * MatchTest
>  * Projection2Test
>  * ProjectionTest
>  * ScrollingTest
> As a result, when it comes to modifying ES Adapter(bug fix or new features), like the [discussion|https://github.com/apache/calcite/pull/2657#discussion_r774472022] mentioned, it's unreasonable to add all the test cases in AggregationTest.java or somewhere else not that suitable.
> So, the RestClient timeout issue during CI should be fixed.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)