[GitHub] [airflow] uranusjr commented on a diff in pull request #24312: switching from `cx-Oracle` to `oracledb`

[GitBox <gi...@apache.org>]

uranusjr commented on code in PR #24312:
URL: https://github.com/apache/airflow/pull/24312#discussion_r891925281


##########
airflow/providers/oracle/hooks/oracle.py:
##########
@@ -119,51 +117,40 @@ def get_conn(self) -> 'OracleHook':
                     dsn += "/" + conn.schema
             conn_config['dsn'] = dsn
 
-        if 'encoding' in conn.extra_dejson:
-            conn_config['encoding'] = conn.extra_dejson.get('encoding')
-            # if `encoding` is specific but `nencoding` is not
-            # `nencoding` should use same values as `encoding` to set encoding, inspired by
-            # https://github.com/oracle/python-cx_Oracle/issues/157#issuecomment-371877993
-            if 'nencoding' not in conn.extra_dejson:
-                conn_config['nencoding'] = conn.extra_dejson.get('encoding')
-        if 'nencoding' in conn.extra_dejson:
-            conn_config['nencoding'] = conn.extra_dejson.get('nencoding')
-        if 'threaded' in conn.extra_dejson:
-            conn_config['threaded'] = conn.extra_dejson.get('threaded')

Review Comment:
   Why are these removed? I would assume at least `encoding` needs to be kept?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org