[jira] [Commented] (HBASE-8197) Cannot distinguish between HBase default config value and client overridden config value

["Jonathan Hsieh (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-8197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13615543#comment-13615543 ] 

Jonathan Hsieh commented on HBASE-8197:
---------------------------------------

Is this sufficient? (notice the "Loaded from ..." comment).

{code}
[jon@a1222 ~]$ hbase org.apache.hadoop.hbase.HBaseConfiguration
<?xml version="1.0" encoding="UTF-8" standalone="no"?><configuration>
<property><!--Loaded from hbase-default.xml--><name>hbase.online.schema.update.enable</name><value>false</value></property>
<property><!--Loaded from hbase-site.xml--><name>hbase.master.port</name><value>57000</value></property>
...
{code}
                
> Cannot distinguish between HBase default config value and client overridden config value
> ----------------------------------------------------------------------------------------
>
>                 Key: HBASE-8197
>                 URL: https://issues.apache.org/jira/browse/HBASE-8197
>             Project: HBase
>          Issue Type: Bug
>          Components: Usability
>    Affects Versions: 0.94.6
>            Reporter: James Taylor
>            Priority: Minor
>
> By HBase setting default values in hbase-default.xml, it makes it difficult for a platform to know if a value has been overridden by the client. For example, Phoenix has a default value it would like to use for hbase.client.scanner.caching. I'd like to be able to call config.setIfUnset option to use our default value if a client hasn't already provided their own. Since HBase sets this in hbase-default.xml to 1, I can't differentiate between the client have a value in their hbase-sites.xml as 1 versus the default value we're getting from HBase.
> Wouldn't it be better if HBase had constants defined in a Java interface that would be used by HBase as the default value if none other is provided, like this:
>     config.getInt("hbase.client.scanner.caching", HBaseDefault.CLIENT_SCANNER_CACHING);

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira