You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dubbo.apache.org by li...@apache.org on 2019/10/01 14:48:02 UTC
[dubbo] 02/03: remove or replace unreachable URL links.
This is an automated email from the ASF dual-hosted git repository.
liujun pushed a commit to branch 2.7.4-release
in repository https://gitbox.apache.org/repos/asf/dubbo.git
commit 805e2daebd7f05229281f074ed85dc9dbf090c14
Author: ken.lj <ke...@gmail.com>
AuthorDate: Mon Sep 30 14:42:11 2019 +0800
remove or replace unreachable URL links.
---
.../java/org/apache/dubbo/common/utils/ConfigUtils.java | 1 -
.../java/org/apache/dubbo/common/bytecode/WrapperTest.java | 6 ------
.../java/org/apache/dubbo/common/utils/ConfigUtilsTest.java | 2 +-
.../org/apache/dubbo/config/AbstractServiceConfigTest.java | 13 ++++++-------
.../dubbo/config/builders/AbstractServiceBuilderTest.java | 4 ++--
.../test/java/org/apache/dubbo/config/url/UrlTestBase.java | 2 +-
.../org/apache/dubbo/remoting/codec/ExchangeCodecTest.java | 1 -
.../common/serialize/gson/GsonJsonObjectOutputTest.java | 2 +-
.../common/serialize/fastjson/FastJsonObjectOutputTest.java | 3 ++-
9 files changed, 13 insertions(+), 21 deletions(-)
diff --git a/dubbo-common/src/main/java/org/apache/dubbo/common/utils/ConfigUtils.java b/dubbo-common/src/main/java/org/apache/dubbo/common/utils/ConfigUtils.java
index 072b456..c1f4711 100644
--- a/dubbo-common/src/main/java/org/apache/dubbo/common/utils/ConfigUtils.java
+++ b/dubbo-common/src/main/java/org/apache/dubbo/common/utils/ConfigUtils.java
@@ -260,7 +260,6 @@ public class ConfigUtils {
String errMsg = String.format("only 1 %s file is expected, but %d dubbo.properties files found on class path: %s",
fileName, list.size(), list.toString());
logger.warn(errMsg);
- // throw new IllegalStateException(errMsg); // see http://code.alibabatech.com/jira/browse/DUBBO-133
}
// fall back to use method getResourceAsStream
diff --git a/dubbo-common/src/test/java/org/apache/dubbo/common/bytecode/WrapperTest.java b/dubbo-common/src/test/java/org/apache/dubbo/common/bytecode/WrapperTest.java
index 75f8972..d3c4d90 100644
--- a/dubbo-common/src/test/java/org/apache/dubbo/common/bytecode/WrapperTest.java
+++ b/dubbo-common/src/test/java/org/apache/dubbo/common/bytecode/WrapperTest.java
@@ -113,9 +113,6 @@ public class WrapperTest {
});
}
- /**
- * see http://code.alibabatech.com/jira/browse/DUBBO-571
- */
@Test
public void test_getDeclaredMethodNames_ContainExtendsParentMethods() throws Exception {
assertArrayEquals(new String[]{"hello",}, Wrapper.getWrapper(Parent1.class).getMethodNames());
@@ -123,9 +120,6 @@ public class WrapperTest {
assertArrayEquals(new String[]{}, Wrapper.getWrapper(Son.class).getDeclaredMethodNames());
}
- /**
- * see http://code.alibabatech.com/jira/browse/DUBBO-571
- */
@Test
public void test_getMethodNames_ContainExtendsParentMethods() throws Exception {
assertArrayEquals(new String[]{"hello", "world"}, Wrapper.getWrapper(Son.class).getMethodNames());
diff --git a/dubbo-common/src/test/java/org/apache/dubbo/common/utils/ConfigUtilsTest.java b/dubbo-common/src/test/java/org/apache/dubbo/common/utils/ConfigUtilsTest.java
index 21b9417..1f82a52 100644
--- a/dubbo-common/src/test/java/org/apache/dubbo/common/utils/ConfigUtilsTest.java
+++ b/dubbo-common/src/test/java/org/apache/dubbo/common/utils/ConfigUtilsTest.java
@@ -229,7 +229,7 @@ public class ConfigUtilsTest {
}
- @Disabled("see http://code.alibabatech.com/jira/browse/DUBBO-133")
+ @Disabled("Not know why disabled, the original link explaining this was reachable.")
@Test
public void testLoadPropertiesMultiFileNotRootPathException() throws Exception {
try {
diff --git a/dubbo-config/dubbo-config-api/src/test/java/org/apache/dubbo/config/AbstractServiceConfigTest.java b/dubbo-config/dubbo-config-api/src/test/java/org/apache/dubbo/config/AbstractServiceConfigTest.java
index 3f12e44..ed5144d 100644
--- a/dubbo-config/dubbo-config-api/src/test/java/org/apache/dubbo/config/AbstractServiceConfigTest.java
+++ b/dubbo-config/dubbo-config-api/src/test/java/org/apache/dubbo/config/AbstractServiceConfigTest.java
@@ -25,16 +25,15 @@ import java.util.Collections;
import java.util.HashMap;
import java.util.Map;
+import static org.apache.dubbo.rpc.Constants.EXPORTER_LISTENER_KEY;
+import static org.apache.dubbo.rpc.Constants.SERVICE_FILTER_KEY;
+import static org.hamcrest.MatcherAssert.assertThat;
import static org.hamcrest.Matchers.equalTo;
import static org.hamcrest.Matchers.hasEntry;
import static org.hamcrest.Matchers.hasSize;
import static org.hamcrest.Matchers.is;
import static org.hamcrest.Matchers.notNullValue;
import static org.hamcrest.Matchers.nullValue;
-import static org.hamcrest.MatcherAssert.assertThat;
-
-import static org.apache.dubbo.rpc.Constants.SERVICE_FILTER_KEY;
-import static org.apache.dubbo.rpc.Constants.EXPORTER_LISTENER_KEY;
public class AbstractServiceConfigTest {
@Test
@@ -75,11 +74,11 @@ public class AbstractServiceConfigTest {
@Test
public void testDocument() throws Exception {
ServiceConfig serviceConfig = new ServiceConfig();
- serviceConfig.setDocument("http://dubbo.io");
- assertThat(serviceConfig.getDocument(), equalTo("http://dubbo.io"));
+ serviceConfig.setDocument("http://dubbo.apache.org");
+ assertThat(serviceConfig.getDocument(), equalTo("http://dubbo.apache.org"));
Map<String, String> parameters = new HashMap<String, String>();
AbstractServiceConfig.appendParameters(parameters, serviceConfig);
- assertThat(parameters, hasEntry("document", "http%3A%2F%2Fdubbo.io"));
+ assertThat(parameters, hasEntry("document", "http%3A%2F%2Fdubbo.apache.org"));
}
@Test
diff --git a/dubbo-config/dubbo-config-api/src/test/java/org/apache/dubbo/config/builders/AbstractServiceBuilderTest.java b/dubbo-config/dubbo-config-api/src/test/java/org/apache/dubbo/config/builders/AbstractServiceBuilderTest.java
index 59dee6e..d07fdd9 100644
--- a/dubbo-config/dubbo-config-api/src/test/java/org/apache/dubbo/config/builders/AbstractServiceBuilderTest.java
+++ b/dubbo-config/dubbo-config-api/src/test/java/org/apache/dubbo/config/builders/AbstractServiceBuilderTest.java
@@ -75,8 +75,8 @@ class AbstractServiceBuilderTest {
@Test
void document() {
ServiceBuilder builder = new ServiceBuilder();
- builder.document("http://dubbo.io");
- Assertions.assertEquals("http://dubbo.io", builder.build().getDocument());
+ builder.document("http://dubbo.apache.org");
+ Assertions.assertEquals("http://dubbo.apache.org", builder.build().getDocument());
}
@Test
diff --git a/dubbo-config/dubbo-config-api/src/test/java/org/apache/dubbo/config/url/UrlTestBase.java b/dubbo-config/dubbo-config-api/src/test/java/org/apache/dubbo/config/url/UrlTestBase.java
index 950b89e..1a313bb 100644
--- a/dubbo-config/dubbo-config-api/src/test/java/org/apache/dubbo/config/url/UrlTestBase.java
+++ b/dubbo-config/dubbo-config-api/src/test/java/org/apache/dubbo/config/url/UrlTestBase.java
@@ -66,7 +66,7 @@ public class UrlTestBase {
{"deprecated", "deprecated", "boolean", false, true, "", "", "", "", ""},
{"dynamic", "dynamic", "boolean", true, false, "", "", "", "", ""},
{"accesslog", "accesslog", "string", "", "haominTest", "", "", "", "", ""},
- {"document", "document", "string", "", "http://b2b-doc.alibaba-inc.com/display/RC/dubbo_devguide.htm?testquery=你好你好", "", "", "", "", ""},
+ {"document", "document", "string", "", "http://dubbo.apache.org/zh-cn/docs/user/quick-start.html?testquery=你好你好", "", "", "", "", ""},
{"weight", "weight", "int", 0, 90, "", "", "", "", ""},
//{"filter", "service.filter", "string", "", "", "", "", "", "", ""},
diff --git a/dubbo-remoting/dubbo-remoting-api/src/test/java/org/apache/dubbo/remoting/codec/ExchangeCodecTest.java b/dubbo-remoting/dubbo-remoting-api/src/test/java/org/apache/dubbo/remoting/codec/ExchangeCodecTest.java
index d4af378..4b074ba 100644
--- a/dubbo-remoting/dubbo-remoting-api/src/test/java/org/apache/dubbo/remoting/codec/ExchangeCodecTest.java
+++ b/dubbo-remoting/dubbo-remoting-api/src/test/java/org/apache/dubbo/remoting/codec/ExchangeCodecTest.java
@@ -402,7 +402,6 @@ public class ExchangeCodecTest extends TelnetCodecTest {
// Assertions.assertEquals(response.getProtocolVersion(), obj.getVersion());
}
- // http://code.alibabatech.com/jira/browse/DUBBO-392
@Test
public void testMessageLengthGreaterThanMessageActualLength() throws Exception {
Channel channel = getCliendSideChannel(url);
diff --git a/dubbo-serialization/dubbo-serialization-gson/src/test/java/org/apache/dubbo/common/serialize/gson/GsonJsonObjectOutputTest.java b/dubbo-serialization/dubbo-serialization-gson/src/test/java/org/apache/dubbo/common/serialize/gson/GsonJsonObjectOutputTest.java
index 5de73c1..0ff2633 100644
--- a/dubbo-serialization/dubbo-serialization-gson/src/test/java/org/apache/dubbo/common/serialize/gson/GsonJsonObjectOutputTest.java
+++ b/dubbo-serialization/dubbo-serialization-gson/src/test/java/org/apache/dubbo/common/serialize/gson/GsonJsonObjectOutputTest.java
@@ -126,7 +126,7 @@ public class GsonJsonObjectOutputTest {
@Test
public void testWriteObject() throws IOException, ClassNotFoundException {
- Image image = new Image("http://dubbo.io/logo.png", "logo", 300, 480, Image.Size.SMALL);
+ Image image = new Image("http://dubbo.apache.org/img/dubbo_white.png", "logo", 300, 480, Image.Size.SMALL);
this.gsonJsonObjectOutput.writeObject(image);
this.flushToInput();
diff --git a/dubbo-serialization/dubbo-serialization-test/src/test/java/org/apache/dubbo/common/serialize/fastjson/FastJsonObjectOutputTest.java b/dubbo-serialization/dubbo-serialization-test/src/test/java/org/apache/dubbo/common/serialize/fastjson/FastJsonObjectOutputTest.java
index c851855..48fb1ce 100644
--- a/dubbo-serialization/dubbo-serialization-test/src/test/java/org/apache/dubbo/common/serialize/fastjson/FastJsonObjectOutputTest.java
+++ b/dubbo-serialization/dubbo-serialization-test/src/test/java/org/apache/dubbo/common/serialize/fastjson/FastJsonObjectOutputTest.java
@@ -17,6 +17,7 @@
package org.apache.dubbo.common.serialize.fastjson;
import org.apache.dubbo.common.serialize.model.media.Image;
+
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
@@ -124,7 +125,7 @@ public class FastJsonObjectOutputTest {
@Test
public void testWriteObject() throws IOException, ClassNotFoundException {
- Image image = new Image("http://dubbo.io/logo.png", "logo", 300, 480, Image.Size.SMALL);
+ Image image = new Image("http://dubbo.apache.org/img/dubbo_white.png", "logo", 300, 480, Image.Size.SMALL);
this.fastJsonObjectOutput.writeObject(image);
this.flushToInput();