You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/06/10 16:52:25 UTC

[GitHub] [beam] tvalentyn commented on a change in pull request #11970: [BEAM-7672] add cp37 wheel to acceptableWhlSpecs

tvalentyn commented on a change in pull request #11970:
URL: https://github.com/apache/beam/pull/11970#discussion_r438270807



##########
File path: sdks/python/container/boot.go
##########
@@ -38,7 +38,7 @@ import (
 )
 
 var (
-	acceptableWhlSpecs = []string{"cp27-cp27mu-manylinux1_x86_64.whl"}
+	acceptableWhlSpecs = []string{"cp27-cp27mu-manylinux1_x86_64.whl", "cp37-cp37m-manylinux1_x86_64.whl"}

Review comment:
       35, 36, and (soon) 38 wheels also should be accepted. We could run a command to python interpreter to get current version, construct the accepted wheel based on that.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org