[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #8266: Move all prestodb dependencies into a separated module

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #8266:
URL: https://github.com/apache/pinot/pull/8266#discussion_r816966933



##########
File path: pinot-connectors/pom.xml
##########
@@ -39,10 +39,19 @@
 
   <modules>
     <module>pinot-spark-connector</module>
-    <module>presto-pinot-driver</module>
   </modules>
 
-  <dependencies>
-  </dependencies>
-
+  <profiles>
+    <profile>
+      <id>presto-driver</id>
+      <activation>
+        <activeByDefault>false</activeByDefault>
+      </activation>
+      <modules>
+        <module>pinot-spark-connector</module>

Review comment:
       Should this be included?

##########
File path: pinot-connectors/presto-pinot-driver/pom.xml
##########
@@ -52,7 +53,8 @@
 
         <dependency>
             <groupId>org.apache.pinot</groupId>
-            <artifactId>pinot-spi</artifactId>
+            <artifactId>pinot-spi-jdk8</artifactId>

Review comment:
       Since the source code are the same, do we need to add these new modules?

##########
File path: pinot-connectors/presto-pinot-driver/pom.xml
##########
@@ -36,6 +36,7 @@
     <properties>
         <pinot.root>${basedir}/../..</pinot.root>
         <shadeBase>org.apache.pinot.\$internal</shadeBase>
+        <jdk.version>8</jdk.version>

Review comment:
       Does this still require code to be java 8 compatible?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org