You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2023/01/04 12:25:17 UTC

[GitHub] [doris] englefly opened a new pull request, #15623: [fix](nereids) binding group by key on agg.output if output is slot

englefly opened a new pull request, #15623:
URL: https://github.com/apache/doris/pull/15623

   # Proposed changes
   case 1
   `select count(1) from t1 join t2 on t1.a = t2.a group by a`
   `group by a` is ambiguous
   
   case 2
   `select t1.a from t1 join t2 on t1.a = t2.a group by a`
   `group by a` is bound on t1.a
   
   Issue Number: close #xxx
   
   ## Problem summary
   
   Describe your changes.
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: 
       - [ ] Yes
       - [ ] No
       - [ ] I don't know
   2. Has unit tests been added:
       - [ ] Yes
       - [ ] No
       - [ ] No Need
   3. Has document been added or modified:
       - [ ] Yes
       - [ ] No
       - [ ] No Need
   4. Does it need to update dependencies:
       - [ ] Yes
       - [ ] No
   5. Are there any changes that cannot be rolled back:
       - [ ] Yes (If Yes, please explain WHY)
       - [ ] No
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] morrySnow merged pull request #15623: [fix](nereids) binding group by key on agg.output if output is slot

Posted by GitBox <gi...@apache.org>.
morrySnow merged PR #15623:
URL: https://github.com/apache/doris/pull/15623


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] hello-stephen commented on pull request #15623: [fix](nereids) binding group by key on agg.output if output is slot

Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #15623:
URL: https://github.com/apache/doris/pull/15623#issuecomment-1371103371

   TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 36.83 seconds
    load time: 648 seconds
    storage size: 17123141282 Bytes
    https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230104155312_clickbench_pr_73644.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] github-actions[bot] commented on pull request #15623: [fix](nereids) binding group by key on agg.output if output is slot

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15623:
URL: https://github.com/apache/doris/pull/15623#issuecomment-1379974541

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] github-actions[bot] commented on pull request #15623: [fix](nereids) binding group by key on agg.output if output is slot

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15623:
URL: https://github.com/apache/doris/pull/15623#issuecomment-1379974498

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] englefly commented on pull request #15623: [fix](nereids) binding group by key on agg.output if output is slot

Posted by GitBox <gi...@apache.org>.
englefly commented on PR #15623:
URL: https://github.com/apache/doris/pull/15623#issuecomment-1375587848

   > add regression test case please
   Add UTs to check exprID.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] morrySnow commented on pull request #15623: [fix](nereids) binding group by key on agg.output if output is slot

Posted by GitBox <gi...@apache.org>.
morrySnow commented on PR #15623:
URL: https://github.com/apache/doris/pull/15623#issuecomment-1377652712

   need rebase to newest master to pass compile


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org