Re: [PR] [SPARK-45830][CORE] Refactor `StorageUtils#bufferCleaner` to avoid directly using classes under the `sun` package [spark]

["LuciferYang (via GitHub)" <gi...@apache.org>]

LuciferYang commented on PR #43675:
URL: https://github.com/apache/spark/pull/43675#issuecomment-1803110236

   > Do you think there is a chance of performance difference, @LuciferYang ?
   
   `cleanMethod.invoke(cleanerMethod.invoke(buffer))` vs `cleanerMethod.invoke(unsafe, buffer)`?
   
   Although the official recommendation is for the former rather than reflection, I have previously done some mircabenchmarks on Java 8 and there is no significant performance difference between the two. If necessary, I can write some more cases to compare them in Java 17.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org