[GitHub] [kafka] mjsax commented on a change in pull request #9120: KAFKA-10316: Consider renaming getter method for Interactive Queries

[GitBox <gi...@apache.org>]

mjsax commented on a change in pull request #9120:
URL: https://github.com/apache/kafka/pull/9120#discussion_r465106657



##########
File path: streams/src/main/java/org/apache/kafka/streams/KeyQueryMetadata.java
##########
@@ -71,11 +75,40 @@ public HostInfo getActiveHost() {
      * Get the Store partition corresponding to the key.
      *
      * @return store partition number
+     * @deprecated Use {@link #partition()} instead.
      */
+    @Deprecated
     public int getPartition() {
         return partition;
     }
 
+    /**
+     * Get the Active streams instance for given key

Review comment:
       Nit: `[a]ctive` (i understand that it's just c&p but it seem wrong in the original JavaDoc, too.
   
   `streams` -> `Kafka Streams`
   
   Also, missing `.` at the end of the sentence.

##########
File path: streams/src/main/java/org/apache/kafka/streams/KeyQueryMetadata.java
##########
@@ -71,11 +75,40 @@ public HostInfo getActiveHost() {
      * Get the Store partition corresponding to the key.
      *
      * @return store partition number
+     * @deprecated Use {@link #partition()} instead.
      */
+    @Deprecated
     public int getPartition() {
         return partition;
     }
 
+    /**
+     * Get the Active streams instance for given key
+     *
+     * @return active instance's {@link HostInfo}
+     */
+    public HostInfo activeHost() {
+        return activeHost;
+    }
+
+    /**
+     * Get the Streams instances that host the key as standbys
+     *
+     * @return set of standby {@link HostInfo} or a empty set, if no standbys are configured
+     */
+    public Set<HostInfo> standbyHosts() {
+        return standbyHosts;
+    }
+
+    /**
+     * Get the Store partition corresponding to the key.

Review comment:
       `[s]tore`

##########
File path: streams/src/main/java/org/apache/kafka/streams/KeyQueryMetadata.java
##########
@@ -71,11 +75,40 @@ public HostInfo getActiveHost() {
      * Get the Store partition corresponding to the key.
      *
      * @return store partition number
+     * @deprecated Use {@link #partition()} instead.
      */
+    @Deprecated
     public int getPartition() {
         return partition;
     }
 
+    /**
+     * Get the Active streams instance for given key
+     *
+     * @return active instance's {@link HostInfo}
+     */
+    public HostInfo activeHost() {
+        return activeHost;
+    }
+
+    /**
+     * Get the Streams instances that host the key as standbys

Review comment:
       nit: `Streams` -> `Kafka Streams`
   
   Also, missing `.` at the end of the sentence.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org