You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by jongyoul <gi...@git.apache.org> on 2017/01/06 13:57:55 UTC
[GitHub] zeppelin pull request #1862: [HOTFIX] Removed non-string properties values s...
GitHub user jongyoul opened a pull request:
https://github.com/apache/zeppelin/pull/1862
[HOTFIX] Removed non-string properties values since it's not used
### What is this PR for?
Removing an error when users try to connect running interpreter. Zeppelin Server passes those properties into RemoteInterpreter when it starts with RemoteInterpreter. But it supports only Map<String, String> type for now, thus port information will make an error and also those information were not used in any code
### What type of PR is it?
[Hot Fix]
### Todos
* [ ] - Remove some properties
### What is the Jira issue?
N/A
### How should this be tested?
`Connect to existing process` should work well
### Screenshots (if appropriate)
N/A
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jongyoul/zeppelin hotfix/remove-non-string-properties
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1862.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1862
----
commit eaec6dee651e5806f9b0f2443f1a638e62ee8f54
Author: Jongyoul Lee <jo...@gmail.com>
Date: 2017-01-06T13:29:19Z
Removed non-string properties values since it's not used
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1862: [HOTFIX] Removed non-string properties values since it...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1862
@cloverhearts Can you make a new PR of writing test cases?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1862: [HOTFIX] Removed non-string properties values since it...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1862
Great! I guess I was asking if it's possible to have automated tests so it wouldn't break in the future.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1862: [HOTFIX] Removed non-string properties values since it...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1862
It's good idea to make it but, for now, we cannot do it because we have zombie process problem when we test it. I think we can do it after we solve that former problem.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1862: [HOTFIX] Removed non-string properties values s...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1862
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1862: [HOTFIX] Removed non-string properties values since it...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/1862
Hello @felixcheung
I have created and tested a remote interpreter.
1. Go to zeppelin/bin.
2. Run the following:
��� `bin/bash ./interpreter.sh -d ../interpreter/python -p 20000> / dev / null`
3. Create a python interpreter group on zeppelin web. (For example, "mypython")
4. Click the edit button.
5. Enter `host: localhost`,` port: 20000` as the remote access interpreter address.
6. Save and run the following in the paragraph:
`` `
%mypython
print ("helloworld")
`` `
If everything works properly, everything is working fine.
This did not work properly in the previous Master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1862: [HOTFIX] Removed non-string properties values since it...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1862
Tested and LGTM!
Thanks @jongyoul
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1862: [HOTFIX] Removed non-string properties values since it...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1862
LGTM
should there be tests for this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1862: [HOTFIX] Removed non-string properties values since it...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/1862
@jongyoul
Yes, I was take look!
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1862: [HOTFIX] Removed non-string properties values since it...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1862
@cloverhearts Can you look into it? I think it can solve the problem.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1862: [HOTFIX] Removed non-string properties values since it...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/1862
@jongyoul Sure :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---