You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/04/23 20:27:45 UTC
[GitHub] [helix] pkuwm opened a new pull request #966: Fix failed tests in helix-rest
pkuwm opened a new pull request #966:
URL: https://github.com/apache/helix/pull/966
### Issues
- [ ] My PR addresses the following Helix issues and references them in the PR description:
Fixes #965
### Description
- [ ] Here are some details about my PR, including screenshots of any UI changes:
- In these tests, the zkClient is trying to read/write ZNRecords, but zkClient's serializer is not a `ZNRecordSerializer` but a `BasicZkSerializer`. So when read/write a ZNRecord, a `ZkMarshallingError` is thrown and causes the tests failed.
- Change the zkClient to `_gZkClientTestNS` which uses ZNRecordSerializer
### Tests
- [ ] The following tests are written for this issue:
Fix tests:
- TestZkRoutingDataWriter
- TestZkRoutingDataReader
- [ ] The following is the result of the "mvn test" command on the appropriate module:
```
[INFO] Tests run: 159, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 44.264 s - in TestSuite
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 159, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 50.445 s
[INFO] Finished at: 2020-04-23T13:12:15-07:00
[INFO] ------------------------------------------------------------------------
```
### Commits
- [ ] My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation (Optional)
- [ ] In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Code Quality
- [ ] My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] pkuwm commented on pull request #966: Fix failed tests in helix-rest
Posted by GitBox <gi...@apache.org>.
pkuwm commented on pull request #966:
URL: https://github.com/apache/helix/pull/966#issuecomment-619217478
This PR is ready to be merged, approved by @dasahcc
```
In tests: TestZkRoutingDataWriter and TestZkRoutingDataReader, the zkClient is trying to read/write ZNRecords, however, zkClient's serializer is not a ZNRecordSerializer but a BasicZkSerializer. So when read/write a ZNRecord, a ZkMarshallingError is thrown and causes the tests failed.
This commit fixes it by changing the zkClient to _gZkClientTestNS which uses ZNRecordSerializer.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org