You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/02/25 03:45:53 UTC

[GitHub] [dolphinscheduler-website] QuakeWang opened a new pull request #703: [Bug] [Doc] Fix e2e-test dead link

QuakeWang opened a new pull request #703:
URL: https://github.com/apache/dolphinscheduler-website/pull/703


   close: https://github.com/apache/dolphinscheduler/issues/8535


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler-website] QuakeWang commented on a change in pull request #703: [Bug] [Doc] Fix e2e-test dead link

Posted by GitBox <gi...@apache.org>.
QuakeWang commented on a change in pull request #703:
URL: https://github.com/apache/dolphinscheduler-website/pull/703#discussion_r814490316



##########
File path: community/en-us/join/e2e-guide.md
##########
@@ -29,7 +29,7 @@ In each issue, we list the content to be tested and the expected results, which
 
 ### How to write test code?
 
-After taking up the corresponding task, the next step is to get to the crux of writing the code. Many partners may not be familiar with E2E test codes, so you can refer to this page: [e2e-test](../../../development/zh-cn/e2e-test.md).
+After taking up the corresponding task, the next step is to get to the crux of writing the code. Many partners may not be familiar with E2E test codes, so you can refer to this page: [e2e-test](../../../en-us/development/e2e-test.md).

Review comment:
       > I mean, we should use the link `[e2e-test](https://dolphinscheduler.apache.org/en-us/development/e2e-test.html)`
   
   I have updated it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler-website] zhongjiajie merged pull request #703: [Bug] [Doc] Fix e2e-test dead link

Posted by GitBox <gi...@apache.org>.
zhongjiajie merged pull request #703:
URL: https://github.com/apache/dolphinscheduler-website/pull/703


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler-website] zhongjiajie commented on pull request #703: [Bug] [Doc] Fix e2e-test dead link

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on pull request #703:
URL: https://github.com/apache/dolphinscheduler-website/pull/703#issuecomment-1050562339


   > > 😭 I remind that it maybe not work in [#699 (comment)](https://github.com/apache/dolphinscheduler-website/pull/699#discussion_r811746689)
   > 
   > That is my bad, I only checked the link of pull request, and the link of e2e-test was forgotten.
   
   It's alright, we fix it ASAP


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler-website] zhongjiajie commented on pull request #703: [Bug] [Doc] Fix e2e-test dead link

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on pull request #703:
URL: https://github.com/apache/dolphinscheduler-website/pull/703#issuecomment-1050514685


   😭  I remind that it maybe not work in https://github.com/apache/dolphinscheduler-website/pull/699#discussion_r811746689 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler-website] SbloodyS commented on pull request #703: [Bug] [Doc] Fix e2e-test dead link

Posted by GitBox <gi...@apache.org>.
SbloodyS commented on pull request #703:
URL: https://github.com/apache/dolphinscheduler-website/pull/703#issuecomment-1050495152


   @zhongjiajie Please review. Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler-website] zhongjiajie commented on a change in pull request #703: [Bug] [Doc] Fix e2e-test dead link

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on a change in pull request #703:
URL: https://github.com/apache/dolphinscheduler-website/pull/703#discussion_r814472301



##########
File path: community/en-us/join/e2e-guide.md
##########
@@ -29,7 +29,7 @@ In each issue, we list the content to be tested and the expected results, which
 
 ### How to write test code?
 
-After taking up the corresponding task, the next step is to get to the crux of writing the code. Many partners may not be familiar with E2E test codes, so you can refer to this page: [e2e-test](../../../development/zh-cn/e2e-test.md).
+After taking up the corresponding task, the next step is to get to the crux of writing the code. Many partners may not be familiar with E2E test codes, so you can refer to this page: [e2e-test](../../../en-us/development/e2e-test.md).

Review comment:
       I take a quick look, our document will change the path when we build from source. maybe we should add full http when we need to link between `community` and `developer` tab, just like `[Contributing Guides](https://dolphinscheduler.apache.org/en-us/community/development/contribute.html)` in https://dolphinscheduler.apache.org/en-us/community/team.html




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler-website] zhongjiajie commented on a change in pull request #703: [Bug] [Doc] Fix e2e-test dead link

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on a change in pull request #703:
URL: https://github.com/apache/dolphinscheduler-website/pull/703#discussion_r814472664



##########
File path: community/en-us/join/e2e-guide.md
##########
@@ -29,7 +29,7 @@ In each issue, we list the content to be tested and the expected results, which
 
 ### How to write test code?
 
-After taking up the corresponding task, the next step is to get to the crux of writing the code. Many partners may not be familiar with E2E test codes, so you can refer to this page: [e2e-test](../../../development/zh-cn/e2e-test.md).
+After taking up the corresponding task, the next step is to get to the crux of writing the code. Many partners may not be familiar with E2E test codes, so you can refer to this page: [e2e-test](../../../en-us/development/e2e-test.md).

Review comment:
       I mean, we should use the link `[e2e-test](https://dolphinscheduler.apache.org/en-us/development/e2e-test.html)`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler-website] QuakeWang commented on pull request #703: [Bug] [Doc] Fix e2e-test dead link

Posted by GitBox <gi...@apache.org>.
QuakeWang commented on pull request #703:
URL: https://github.com/apache/dolphinscheduler-website/pull/703#issuecomment-1050542311


   > 😭 I remind that it maybe not work in [#699 (comment)](https://github.com/apache/dolphinscheduler-website/pull/699#discussion_r811746689)
   
   
   That is my bad, I only checked the link of pull request, and the link of e2e-test was forgotten.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org