[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #5158: Compare NULL types

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #5158:
URL: https://github.com/apache/arrow-datafusion/pull/5158#discussion_r1094863478


##########
datafusion/core/tests/sqllogictests/test_files/pg_compat/pg_compat_type_coercion.slt:
##########
@@ -95,20 +95,17 @@ select pg_typeof(false or true), pg_typeof(true or false);
 bool bool
 
 
-# TODO: run for DataFusion as well after #4335
-onlyif postgres
 query ??
 select null and null, null or null;
 ----
 NULL NULL
 
 
-# TODO: uncomment after #4335
-#onlyif DataFusion
-#query ??
-#select arrow_typeof(null and null), arrow_typeof(null or null);
-#----
-#Boolean Boolean
+onlyif DataFusion
+query ??
+select arrow_typeof(null and null), arrow_typeof(null or null);

Review Comment:
   👍 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org