You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "ByteYue (via GitHub)" <gi...@apache.org> on 2023/11/21 13:19:51 UTC

[PR] [enhance](PrefetchReader) Make the prefetch timeout one config [doris]

ByteYue opened a new pull request, #27371:
URL: https://github.com/apache/doris/pull/27371

   ## Proposed changes
   
   Issue Number: close #xxx
   
   <!--Describe your changes.-->
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhance](PrefetchReader) Make the prefetch timeout one config [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27371:
URL: https://github.com/apache/doris/pull/27371#issuecomment-1821069575

   TeamCity be ut coverage result:
    Function Coverage: 36.52% (8446/23125) 
    Line Coverage: 28.85% (68673/238007)
    Region Coverage: 27.81% (35507/127675)
    Branch Coverage: 24.57% (18110/73712)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/c6020c41a0fee4092ade50ee2f5f4493c89a12ca_c6020c41a0fee4092ade50ee2f5f4493c89a12ca/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhance](PrefetchReader) Make the prefetch timeout one config [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27371:
URL: https://github.com/apache/doris/pull/27371#issuecomment-1821141772

   (From new machine)TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 48.7 seconds
    stream load tsv:          571 seconds loaded 74807831229 Bytes, about 124 MB/s
    stream load json:         18 seconds loaded 2358488459 Bytes, about 124 MB/s
    stream load orc:          66 seconds loaded 1101869774 Bytes, about 15 MB/s
    stream load parquet:          34 seconds loaded 861443392 Bytes, about 24 MB/s
    insert into select:          29.4 seconds inserted 10000000 Rows, about 340K ops/s
    storage size: 17098912668 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhance](PrefetchReader) Make the prefetch timeout one config [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27371:
URL: https://github.com/apache/doris/pull/27371#issuecomment-1825071645

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhance](PrefetchReader) Make the prefetch timeout one config [doris]

Posted by "ByteYue (via GitHub)" <gi...@apache.org>.
ByteYue commented on PR #27371:
URL: https://github.com/apache/doris/pull/27371#issuecomment-1820913836

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhance](PrefetchReader) Make the prefetch timeout one config [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27371:
URL: https://github.com/apache/doris/pull/27371#issuecomment-1820924006

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhance](PrefetchReader) Make the prefetch timeout one config [doris]

Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring merged PR #27371:
URL: https://github.com/apache/doris/pull/27371


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhance](PrefetchReader) Make the prefetch timeout one config [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27371:
URL: https://github.com/apache/doris/pull/27371#issuecomment-1821123975

   
   <details>
   <summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
   
   ```
   Tpch sf100 test result on commit c6020c41a0fee4092ade50ee2f5f4493c89a12ca, data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1	4905	4658	4666	4658
   q2	360	143	167	143
   q3	2020	1946	1961	1946
   q4	1380	1260	1225	1225
   q5	3971	3939	3958	3939
   q6	248	132	136	132
   q7	1424	880	911	880
   q8	2735	2753	2746	2746
   q9	9838	9588	9604	9588
   q10	3472	3520	3523	3520
   q11	385	249	258	249
   q12	446	297	305	297
   q13	4558	3841	3800	3800
   q14	314	283	292	283
   q15	588	540	522	522
   q16	664	586	584	584
   q17	1120	968	934	934
   q18	7756	7301	7342	7301
   q19	1657	1699	1673	1673
   q20	520	329	310	310
   q21	4382	3930	3985	3930
   q22	472	375	380	375
   Total cold run time: 53215 ms
   Total hot run time: 49035 ms
   
   run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
   q1	4592	4563	4561	4561
   q2	348	223	261	223
   q3	4032	4008	3994	3994
   q4	2702	2688	2696	2688
   q5	9654	9656	9701	9656
   q6	238	125	125	125
   q7	3015	2495	2461	2461
   q8	4406	4410	4385	4385
   q9	13151	13158	13073	13073
   q10	4103	4157	4185	4157
   q11	832	646	736	646
   q12	986	788	817	788
   q13	4301	3623	3567	3567
   q14	378	348	344	344
   q15	586	522	514	514
   q16	742	685	671	671
   q17	3842	3863	3880	3863
   q18	9594	9160	9095	9095
   q19	1842	1769	1759	1759
   q20	2393	2084	2069	2069
   q21	8761	8699	8465	8465
   q22	946	799	827	799
   Total cold run time: 81444 ms
   Total hot run time: 77903 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhance](PrefetchReader) Make the prefetch timeout one config [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27371:
URL: https://github.com/apache/doris/pull/27371#issuecomment-1825071673

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org