You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by bhuvnesh chaudhary <bc...@pivotal.io> on 2016/01/12 03:31:59 UTC

Review Request 42175: Blueprint deploy should update the value localhost for HAWQMASTER and HAWQSTANDBY

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42175/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, Jayush Luniya, Oleksandr Diachenko, Richard Zang, and Sumit Mohanty.


Bugs: AMBARI-14621
    https://issues.apache.org/jira/browse/AMBARI-14621


Repository: ambari


Description
-------

Blueprint deploy should update the value localhost for HAWQMASTER and HAWQSTANDBY with the name of the namenode hostname.
The logic to replace the hostname is currently only on the Web UI due to which during deploy, hawq_master_address_host and hawq_standby_address_host are set to localhost and hawq start fails.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java 261798c 
  ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py 95c4eba 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java 21710e5 

Diff: https://reviews.apache.org/r/42175/diff/


Testing
-------

yes. test case added.


Thanks,

bhuvnesh chaudhary


Re: Review Request 42175: Blueprint deploy should update the value localhost for HAWQMASTER and HAWQSTANDBY

Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42175/#review114051
-----------------------------------------------------------


@bhuvnesh please add rnettleton to this review and wait for his review.

- Jayush Luniya


On Jan. 12, 2016, 2:56 a.m., bhuvnesh chaudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42175/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2016, 2:56 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, Jayush Luniya, Oleksandr Diachenko, Richard Zang, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-14621
>     https://issues.apache.org/jira/browse/AMBARI-14621
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Blueprint deploy should update the value localhost for HAWQMASTER, HAWQSTANDBY with the name of their respective component hostname. It should also update the value of hawq_dfs_url to NAMENODE HOST.
> The logic to replace the hostname is currently only on the Web UI due to which during deploy, hawq_master_address_host, hawq_standby_address_host and hawq_dfs_url are set to localhost and hawq start fails.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java 261798c 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py 95c4eba 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java 21710e5 
> 
> Diff: https://reviews.apache.org/r/42175/diff/
> 
> 
> Testing
> -------
> 
> yes. test case added.
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>


Re: Review Request 42175: Blueprint deploy should update the value localhost for HAWQMASTER and HAWQSTANDBY

Posted by bhuvnesh chaudhary <bc...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42175/
-----------------------------------------------------------

(Updated Jan. 12, 2016, 2:56 a.m.)


Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, Jayush Luniya, Oleksandr Diachenko, Richard Zang, and Sumit Mohanty.


Changes
-------

Updated description.


Bugs: AMBARI-14621
    https://issues.apache.org/jira/browse/AMBARI-14621


Repository: ambari


Description (updated)
-------

Blueprint deploy should update the value localhost for HAWQMASTER, HAWQSTANDBY with the name of their respective component hostname. It should also update the value of hawq_dfs_url to NAMENODE HOST.
The logic to replace the hostname is currently only on the Web UI due to which during deploy, hawq_master_address_host, hawq_standby_address_host and hawq_dfs_url are set to localhost and hawq start fails.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java 261798c 
  ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py 95c4eba 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java 21710e5 

Diff: https://reviews.apache.org/r/42175/diff/


Testing
-------

yes. test case added.


Thanks,

bhuvnesh chaudhary