You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by "Shazron Abdullah (Created) (JIRA)" <ji...@apache.org> on 2012/04/03 23:54:24 UTC

[jira] [Created] (CB-433) CDVFileTransfer.m methods - convert use of "options" object into "arguments" array

CDVFileTransfer.m methods - convert use of "options" object into "arguments" array 
-----------------------------------------------------------------------------------

                 Key: CB-433
                 URL: https://issues.apache.org/jira/browse/CB-433
             Project: Apache Callback
          Issue Type: Sub-task
            Reporter: Shazron Abdullah




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CB-433) CDVFileTransfer.m methods - convert use of "options" object into "arguments" array

Posted by "Shazron Abdullah (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CB-433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245853#comment-13245853 ] 

Shazron Abdullah commented on CB-433:
-------------------------------------

Currently broken. JS converts options into arguments.

 1. https://github.com/apache/incubator-cordova-ios/blob/master/CordovaLib/Classes/CDVFileTransfer.m#L28

 2. https://github.com/apache/incubator-cordova-js/blob/master/lib/common/plugin/FileTransfer.js#L40
                
> CDVFileTransfer.m methods - convert use of "options" object into "arguments" array 
> -----------------------------------------------------------------------------------
>
>                 Key: CB-433
>                 URL: https://issues.apache.org/jira/browse/CB-433
>             Project: Apache Callback
>          Issue Type: Sub-task
>          Components: iOS
>            Reporter: Shazron Abdullah
>             Fix For: 1.6.0
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CB-433) CDVFileTransfer.m methods - convert use of "options" object into "arguments" array

Posted by "Shazron Abdullah (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CB-433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245905#comment-13245905 ] 

Shazron Abdullah commented on CB-433:
-------------------------------------

Right now the fix is in my branch, pending testing before it's put into the mainline: https://github.com/shazron/incubator-cordova-ios/commit/faf066d1e67333368a4dc0339467558ed0c9c2d2
                
> CDVFileTransfer.m methods - convert use of "options" object into "arguments" array 
> -----------------------------------------------------------------------------------
>
>                 Key: CB-433
>                 URL: https://issues.apache.org/jira/browse/CB-433
>             Project: Apache Callback
>          Issue Type: Sub-task
>          Components: iOS
>            Reporter: Shazron Abdullah
>            Assignee: Shazron Abdullah
>             Fix For: 1.6.0
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CB-433) CDVFileTransfer.m methods - convert use of "options" object into "arguments" array

Posted by "Shazron Abdullah (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CB-433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245879#comment-13245879 ] 

Shazron Abdullah commented on CB-433:
-------------------------------------

Clarification needed for "debug" parameter in the JS. chunkedMode not handled, doc issue CB-437 created.
                
> CDVFileTransfer.m methods - convert use of "options" object into "arguments" array 
> -----------------------------------------------------------------------------------
>
>                 Key: CB-433
>                 URL: https://issues.apache.org/jira/browse/CB-433
>             Project: Apache Callback
>          Issue Type: Sub-task
>          Components: iOS
>            Reporter: Shazron Abdullah
>            Assignee: Shazron Abdullah
>             Fix For: 1.6.0
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (CB-433) CDVFileTransfer.m methods - convert use of "options" object into "arguments" array

Posted by "Shazron Abdullah (Assigned) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CB-433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shazron Abdullah reassigned CB-433:
-----------------------------------

    Assignee: Shazron Abdullah
    
> CDVFileTransfer.m methods - convert use of "options" object into "arguments" array 
> -----------------------------------------------------------------------------------
>
>                 Key: CB-433
>                 URL: https://issues.apache.org/jira/browse/CB-433
>             Project: Apache Callback
>          Issue Type: Sub-task
>          Components: iOS
>            Reporter: Shazron Abdullah
>            Assignee: Shazron Abdullah
>             Fix For: 1.6.0
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CB-433) CDVFileTransfer.m methods - convert use of "options" object into "arguments" array

Posted by "Shazron Abdullah (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CB-433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245885#comment-13245885 ] 

Shazron Abdullah commented on CB-433:
-------------------------------------

Have to be careful here - since params is expected to be an object, it *won't* be the 6th parameter in arguments, but *will* be the options dictionary instead because of iOS cordova.exec marshalling.

Thus, "debug" and "chunkedMode" will be the 6th and 7th parameters of arguments.
                
> CDVFileTransfer.m methods - convert use of "options" object into "arguments" array 
> -----------------------------------------------------------------------------------
>
>                 Key: CB-433
>                 URL: https://issues.apache.org/jira/browse/CB-433
>             Project: Apache Callback
>          Issue Type: Sub-task
>          Components: iOS
>            Reporter: Shazron Abdullah
>            Assignee: Shazron Abdullah
>             Fix For: 1.6.0
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (CB-433) CDVFileTransfer.m methods - convert use of "options" object into "arguments" array

Posted by "Shazron Abdullah (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CB-433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shazron Abdullah resolved CB-433.
---------------------------------

    Resolution: Fixed

Fix commit: http://git-wip-us.apache.org/repos/asf?p=incubator-cordova-ios.git;a=commit;h=2bac46cefe647ed14d50dce819df6cb3cdd4837f
                
> CDVFileTransfer.m methods - convert use of "options" object into "arguments" array 
> -----------------------------------------------------------------------------------
>
>                 Key: CB-433
>                 URL: https://issues.apache.org/jira/browse/CB-433
>             Project: Apache Callback
>          Issue Type: Sub-task
>          Components: iOS
>            Reporter: Shazron Abdullah
>            Assignee: Shazron Abdullah
>             Fix For: 1.6.0
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira