[GitHub] [skywalking-java] devkanro commented on a change in pull request #72: TracePathMatcher should match pattern "**" with paths end by "/" (#7875)

[GitBox <gi...@apache.org>]

devkanro commented on a change in pull request #72:
URL: https://github.com/apache/skywalking-java/pull/72#discussion_r752041255



##########
File path: apm-sniffer/optional-plugins/trace-ignore-plugin/src/main/java/org/apache/skywalking/apm/plugin/trace/ignore/matcher/FastPathMatcher.java
##########
@@ -124,7 +124,7 @@ private boolean wildcardMatch(String pat, int p, String str, int s) {
     private boolean multiWildcardMatch(String pat, int p, String str, int s) {
         // End of pattern, just check the end of string is '/' quickly.
         if (p >= pat.length() && s < str.length()) {
-            return str.charAt(str.length() - 1) != '/';
+            return true;
         }

Review comment:
       Maybe the comment need be changed.
   
   ```Java
           // End of pattern, make matching success quickly.
           if (p >= pat.length() && s < str.length()) {
               return true;
           }
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org