You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by hb...@apache.org on 2012/05/28 11:30:24 UTC
svn commit: r1343173 - in /maven/plugin-tools/trunk:
maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/
maven-plugin-tools-java/src/test/resources/source/
Author: hboutemy
Date: Mon May 28 09:30:23 2012
New Revision: 1343173
URL: http://svn.apache.org/viewvc?rev=1343173&view=rev
Log:
[MPLUGIN-207] generate since elements in descriptor
Modified:
maven/plugin-tools/trunk/maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginDescriptorGenerator.java
maven/plugin-tools/trunk/maven-plugin-tools-java/src/test/resources/source/Full.java
maven/plugin-tools/trunk/maven-plugin-tools-java/src/test/resources/source/plugin-expected.xml
Modified: maven/plugin-tools/trunk/maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginDescriptorGenerator.java
URL: http://svn.apache.org/viewvc/maven/plugin-tools/trunk/maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginDescriptorGenerator.java?rev=1343173&r1=1343172&r2=1343173&view=diff
==============================================================================
--- maven/plugin-tools/trunk/maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginDescriptorGenerator.java (original)
+++ maven/plugin-tools/trunk/maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginDescriptorGenerator.java Mon May 28 09:30:23 2012
@@ -385,6 +385,26 @@ public class PluginDescriptorGenerator
//
// ----------------------------------------------------------------------
+ if ( mojoDescriptor.getSince() != null )
+ {
+ w.startElement( "since" );
+
+ if ( StringUtils.isEmpty( mojoDescriptor.getSince() ) )
+ {
+ w.writeText( "No version given" );
+ }
+ else
+ {
+ w.writeText( mojoDescriptor.getSince() );
+ }
+
+ w.endElement();
+ }
+
+ // ----------------------------------------------------------------------
+ //
+ // ----------------------------------------------------------------------
+
if ( mojoDescriptor.getDeprecated() != null )
{
w.startElement( "deprecated" );
@@ -479,6 +499,22 @@ public class PluginDescriptorGenerator
GeneratorUtils.element( w, "type", parameter.getType() );
+ if ( parameter.getSince() != null )
+ {
+ w.startElement( "since" );
+
+ if ( StringUtils.isEmpty( parameter.getSince() ) )
+ {
+ w.writeText( "No version given" );
+ }
+ else
+ {
+ w.writeText( parameter.getSince() );
+ }
+
+ w.endElement();
+ }
+
if ( parameter.getDeprecated() != null )
{
if ( StringUtils.isEmpty( parameter.getDeprecated() ) )
Modified: maven/plugin-tools/trunk/maven-plugin-tools-java/src/test/resources/source/Full.java
URL: http://svn.apache.org/viewvc/maven/plugin-tools/trunk/maven-plugin-tools-java/src/test/resources/source/Full.java?rev=1343173&r1=1343172&r2=1343173&view=diff
==============================================================================
--- maven/plugin-tools/trunk/maven-plugin-tools-java/src/test/resources/source/Full.java (original)
+++ maven/plugin-tools/trunk/maven-plugin-tools-java/src/test/resources/source/Full.java Mon May 28 09:30:23 2012
@@ -72,10 +72,7 @@ public class Full
* A component.
*
* @component role="role" roleHint="hint"
- * @readonly
* @required
- * @since tomorrow
- * @deprecated after tomorrow
*/
private MojoScanner component;
Modified: maven/plugin-tools/trunk/maven-plugin-tools-java/src/test/resources/source/plugin-expected.xml
URL: http://svn.apache.org/viewvc/maven/plugin-tools/trunk/maven-plugin-tools-java/src/test/resources/source/plugin-expected.xml?rev=1343173&r1=1343172&r2=1343173&view=diff
==============================================================================
--- maven/plugin-tools/trunk/maven-plugin-tools-java/src/test/resources/source/plugin-expected.xml (original)
+++ maven/plugin-tools/trunk/maven-plugin-tools-java/src/test/resources/source/plugin-expected.xml Mon May 28 09:30:23 2012
@@ -77,6 +77,7 @@
<configurator>"role-hint"</configurator>
<instantiationStrategy>singleton</instantiationStrategy>
<executionStrategy>always</executionStrategy>
+ <since>now</since>
<deprecated>deprecation text test</deprecated>
<requiresDependencyCollection>test</requiresDependencyCollection>
<threadSafe>true</threadSafe>
@@ -85,6 +86,7 @@
<name>file</name>
<alias>myAlias</alias>
<type>java.io.File</type>
+ <since>tomorrow</since>
<deprecated>after tomorrow</deprecated>
<required>true</required>
<editable>false</editable>