You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/04/19 05:36:14 UTC

[GitHub] [pinot] navina commented on pull request #8564: Invoke checkpoint before closing partition group consumer

navina commented on PR #8564:
URL: https://github.com/apache/pinot/pull/8564#issuecomment-1102096897

   > lgtm! Is there ay scope to add a unit test to check that the partitionGroupConsumer starts with the right startOffset across closes?
   
   I took a quick look. It is using a lot of mock/fake classes and based on my understanding, it is not possible to test this behavior easily. :/ 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org