You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/07/13 18:53:24 UTC

[GitHub] [arrow] c-jamie opened a new pull request #7736: ARROW-9440: [Python] Expose Fill Null kernel

c-jamie opened a new pull request #7736:
URL: https://github.com/apache/arrow/pull/7736


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] wesm commented on a change in pull request #7736: ARROW-9440: [Python] Expose Fill Null kernel

Posted by GitBox <gi...@apache.org>.
wesm commented on a change in pull request #7736:
URL: https://github.com/apache/arrow/pull/7736#discussion_r454002163



##########
File path: python/pyarrow/array.pxi
##########
@@ -903,6 +903,21 @@ cdef class Array(_PandasConvertible):
         """
         return _pc().is_valid(self)
 
+    def fill_null(self, Scalar fill_value):

Review comment:
       We should accept any value that's coercible to a Scalar with `pyarrow.scalar`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] wesm closed pull request #7736: ARROW-9440: [Python] Expose Fill Null kernel

Posted by GitBox <gi...@apache.org>.
wesm closed pull request #7736:
URL: https://github.com/apache/arrow/pull/7736


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] wesm commented on pull request #7736: ARROW-9440: [Python] Expose Fill Null kernel

Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #7736:
URL: https://github.com/apache/arrow/pull/7736#issuecomment-657904056


   thanks @c-jamie!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #7736: ARROW-9440: [Python] Expose Fill Null kernel

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7736:
URL: https://github.com/apache/arrow/pull/7736#issuecomment-657736769


   https://issues.apache.org/jira/browse/ARROW-9440


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] wesm commented on pull request #7736: ARROW-9440: [Python] Expose Fill Null kernel

Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #7736:
URL: https://github.com/apache/arrow/pull/7736#issuecomment-657891124


   +1. Will merge on green build


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org