You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by jk...@apache.org on 2015/08/03 11:05:43 UTC
[1/2] tapestry-5 git commit: TAP5-2337: select attribute char once
Repository: tapestry-5
Updated Branches:
refs/heads/master 5397f3a48 -> 13f4070ea
TAP5-2337: select attribute char once
Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/c409f589
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/c409f589
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/c409f589
Branch: refs/heads/master
Commit: c409f589b235ba58fc61007b080dd39b4e53be39
Parents: 5397f3a
Author: Jochen Kemnade <jo...@eddyson.de>
Authored: Fri Jul 31 16:28:09 2015 +0200
Committer: Jochen Kemnade <jo...@eddyson.de>
Committed: Fri Jul 31 16:28:09 2015 +0200
----------------------------------------------------------------------
.../main/java/org/apache/tapestry5/dom/AbstractMarkupModel.java | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/c409f589/tapestry-core/src/main/java/org/apache/tapestry5/dom/AbstractMarkupModel.java
----------------------------------------------------------------------
diff --git a/tapestry-core/src/main/java/org/apache/tapestry5/dom/AbstractMarkupModel.java b/tapestry-core/src/main/java/org/apache/tapestry5/dom/AbstractMarkupModel.java
index cf9bd0b..dd98a89 100644
--- a/tapestry-core/src/main/java/org/apache/tapestry5/dom/AbstractMarkupModel.java
+++ b/tapestry-core/src/main/java/org/apache/tapestry5/dom/AbstractMarkupModel.java
@@ -17,15 +17,17 @@ package org.apache.tapestry5.dom;
public abstract class AbstractMarkupModel implements MarkupModel
{
private final boolean useApostropheForAttributes;
+ private final char attributeQuoteChar;
protected AbstractMarkupModel(boolean useApostropheForAttributes)
{
this.useApostropheForAttributes = useApostropheForAttributes;
+ this.attributeQuoteChar = useApostropheForAttributes ? '\'' : '"';
}
public char getAttributeQuote()
{
- return useApostropheForAttributes ? '\'' : '"';
+ return attributeQuoteChar;
}
/**
[2/2] tapestry-5 git commit: remove leftovers
Posted by jk...@apache.org.
remove leftovers
Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/13f4070e
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/13f4070e
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/13f4070e
Branch: refs/heads/master
Commit: 13f4070eaa4f6333d6ad15704410db649644977f
Parents: c409f58
Author: Jochen Kemnade <jo...@eddyson.de>
Authored: Mon Aug 3 10:53:15 2015 +0200
Committer: Jochen Kemnade <jo...@eddyson.de>
Committed: Mon Aug 3 10:53:15 2015 +0200
----------------------------------------------------------------------
.../src/main/java/org/apache/tapestry5/dom/Element.java | 6 ------
1 file changed, 6 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/13f4070e/tapestry-core/src/main/java/org/apache/tapestry5/dom/Element.java
----------------------------------------------------------------------
diff --git a/tapestry-core/src/main/java/org/apache/tapestry5/dom/Element.java b/tapestry-core/src/main/java/org/apache/tapestry5/dom/Element.java
index 00c1312..bf1eadf 100644
--- a/tapestry-core/src/main/java/org/apache/tapestry5/dom/Element.java
+++ b/tapestry-core/src/main/java/org/apache/tapestry5/dom/Element.java
@@ -21,7 +21,6 @@ import org.apache.tapestry5.ioc.util.Stack;
import java.io.PrintWriter;
import java.util.*;
-import java.util.regex.Pattern;
/**
* An element that will render with a begin tag and attributes, a body, and an end tag. Also acts as a factory for
@@ -42,10 +41,6 @@ public final class Element extends Node
private final Document document;
- private static final Pattern SPACES = Pattern.compile("\\s+");
-
- private static final String[] EMPTY_ARRAY = new String[0];
-
/**
* URI of the namespace which contains the element. A quirk in XML is that the element may be in a namespace it
* defines itself, so resolving the namespace to a prefix must wait until render time (since the Element is created
@@ -961,7 +956,6 @@ public final class Element extends Node
*
* @return unmodifiable list of children nodes
*/
- @SuppressWarnings("unchecked")
public List<Node> getChildren()
{
List<Node> result = CollectionFactory.newList();
[2/2] tapestry-5 git commit: remove leftovers
Posted by jk...@apache.org.
remove leftovers
Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/13f4070e
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/13f4070e
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/13f4070e
Branch: refs/heads/master
Commit: 13f4070eaa4f6333d6ad15704410db649644977f
Parents: c409f58
Author: Jochen Kemnade <jo...@eddyson.de>
Authored: Mon Aug 3 10:53:15 2015 +0200
Committer: Jochen Kemnade <jo...@eddyson.de>
Committed: Mon Aug 3 10:53:15 2015 +0200
----------------------------------------------------------------------
.../src/main/java/org/apache/tapestry5/dom/Element.java | 6 ------
1 file changed, 6 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/13f4070e/tapestry-core/src/main/java/org/apache/tapestry5/dom/Element.java
----------------------------------------------------------------------
diff --git a/tapestry-core/src/main/java/org/apache/tapestry5/dom/Element.java b/tapestry-core/src/main/java/org/apache/tapestry5/dom/Element.java
index 00c1312..bf1eadf 100644
--- a/tapestry-core/src/main/java/org/apache/tapestry5/dom/Element.java
+++ b/tapestry-core/src/main/java/org/apache/tapestry5/dom/Element.java
@@ -21,7 +21,6 @@ import org.apache.tapestry5.ioc.util.Stack;
import java.io.PrintWriter;
import java.util.*;
-import java.util.regex.Pattern;
/**
* An element that will render with a begin tag and attributes, a body, and an end tag. Also acts as a factory for
@@ -42,10 +41,6 @@ public final class Element extends Node
private final Document document;
- private static final Pattern SPACES = Pattern.compile("\\s+");
-
- private static final String[] EMPTY_ARRAY = new String[0];
-
/**
* URI of the namespace which contains the element. A quirk in XML is that the element may be in a namespace it
* defines itself, so resolving the namespace to a prefix must wait until render time (since the Element is created
@@ -961,7 +956,6 @@ public final class Element extends Node
*
* @return unmodifiable list of children nodes
*/
- @SuppressWarnings("unchecked")
public List<Node> getChildren()
{
List<Node> result = CollectionFactory.newList();