You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2016/01/13 16:48:09 UTC

Review Request 42255: Updated user documentation around HTTP response codes.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42255/
-----------------------------------------------------------

Review request for mesos, Alexander Rojas and Till Toenshoff.


Bugs: MESOS-4305
    https://issues.apache.org/jira/browse/MESOS-4305


Repository: mesos


Description
-------

Updated user documentation around HTTP response codes.


Diffs
-----

  docs/persistent-volume.md f969975f242f7fc7a8b7a89e3e211d2201c9114a 
  docs/reservation.md a5dbc0abd5d9aef04064dc2a1dff7eb118147e43 

Diff: https://reviews.apache.org/r/42255/diff/


Testing
-------

None: not a functional change.


Thanks,

Alexander Rukletsov


Re: Review Request 42255: Updated user documentation around HTTP response codes.

Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42255/#review114231
-----------------------------------------------------------

Ship it!


Ship It!

- Alexander Rojas


On Jan. 13, 2016, 4:48 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42255/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2016, 4:48 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Till Toenshoff.
> 
> 
> Bugs: MESOS-4305
>     https://issues.apache.org/jira/browse/MESOS-4305
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated user documentation around HTTP response codes.
> 
> 
> Diffs
> -----
> 
>   docs/persistent-volume.md f969975f242f7fc7a8b7a89e3e211d2201c9114a 
>   docs/reservation.md a5dbc0abd5d9aef04064dc2a1dff7eb118147e43 
> 
> Diff: https://reviews.apache.org/r/42255/diff/
> 
> 
> Testing
> -------
> 
> None: not a functional change.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Re: Review Request 42255: Updated user documentation around HTTP response codes.

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42255/#review114930
-----------------------------------------------------------

Ship it!


Ship It!

- Guangya Liu


On 一月 13, 2016, 3:48 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42255/
> -----------------------------------------------------------
> 
> (Updated 一月 13, 2016, 3:48 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Till Toenshoff.
> 
> 
> Bugs: MESOS-4305
>     https://issues.apache.org/jira/browse/MESOS-4305
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated user documentation around HTTP response codes.
> 
> 
> Diffs
> -----
> 
>   docs/persistent-volume.md f969975f242f7fc7a8b7a89e3e211d2201c9114a 
>   docs/reservation.md a5dbc0abd5d9aef04064dc2a1dff7eb118147e43 
> 
> Diff: https://reviews.apache.org/r/42255/diff/
> 
> 
> Testing
> -------
> 
> None: not a functional change.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Re: Review Request 42255: Updated user documentation around HTTP response codes.

Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42255/#review114223
-----------------------------------------------------------

Ship it!


Ship It!

- haosdent huang


On Jan. 13, 2016, 3:48 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42255/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2016, 3:48 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Till Toenshoff.
> 
> 
> Bugs: MESOS-4305
>     https://issues.apache.org/jira/browse/MESOS-4305
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated user documentation around HTTP response codes.
> 
> 
> Diffs
> -----
> 
>   docs/persistent-volume.md f969975f242f7fc7a8b7a89e3e211d2201c9114a 
>   docs/reservation.md a5dbc0abd5d9aef04064dc2a1dff7eb118147e43 
> 
> Diff: https://reviews.apache.org/r/42255/diff/
> 
> 
> Testing
> -------
> 
> None: not a functional change.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Re: Review Request 42255: Updated user documentation around HTTP response codes.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42255/#review115014
-----------------------------------------------------------


Patch looks great!

Reviews applied: [40539, 37999, 38000, 38094, 38950, 39043, 42027, 42255]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 18, 2016, 11:46 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42255/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2016, 11:46 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Till Toenshoff.
> 
> 
> Bugs: MESOS-4305
>     https://issues.apache.org/jira/browse/MESOS-4305
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated user documentation around HTTP response codes.
> 
> 
> Diffs
> -----
> 
>   docs/persistent-volume.md f969975f242f7fc7a8b7a89e3e211d2201c9114a 
>   docs/reservation.md 57cd92ce5d8d25b3393763614e40155e17e8c06e 
> 
> Diff: https://reviews.apache.org/r/42255/diff/
> 
> 
> Testing
> -------
> 
> None: not a functional change.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Re: Review Request 42255: Updated user documentation around HTTP response codes.

Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42255/#review115494
-----------------------------------------------------------

Ship it!


Ship It!

- Till Toenshoff


On Jan. 18, 2016, 11:46 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42255/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2016, 11:46 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Till Toenshoff.
> 
> 
> Bugs: MESOS-4305
>     https://issues.apache.org/jira/browse/MESOS-4305
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated user documentation around HTTP response codes.
> 
> 
> Diffs
> -----
> 
>   docs/persistent-volume.md f969975f242f7fc7a8b7a89e3e211d2201c9114a 
>   docs/reservation.md 57cd92ce5d8d25b3393763614e40155e17e8c06e 
> 
> Diff: https://reviews.apache.org/r/42255/diff/
> 
> 
> Testing
> -------
> 
> None: not a functional change.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Re: Review Request 42255: Updated user documentation around HTTP response codes.

Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42255/
-----------------------------------------------------------

(Updated Jan. 18, 2016, 11:46 a.m.)


Review request for mesos, Alexander Rojas and Till Toenshoff.


Changes
-------

Rebased.


Bugs: MESOS-4305
    https://issues.apache.org/jira/browse/MESOS-4305


Repository: mesos


Description
-------

Updated user documentation around HTTP response codes.


Diffs (updated)
-----

  docs/persistent-volume.md f969975f242f7fc7a8b7a89e3e211d2201c9114a 
  docs/reservation.md 57cd92ce5d8d25b3393763614e40155e17e8c06e 

Diff: https://reviews.apache.org/r/42255/diff/


Testing
-------

None: not a functional change.


Thanks,

Alexander Rukletsov


Re: Review Request 42255: Updated user documentation around HTTP response codes.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42255/#review114933
-----------------------------------------------------------


Bad patch!

Reviews applied: [40539, 37999, 38000, 38094, 38950, 39043, 42027]

Failed command: ./support/apply-review.sh -n -r 42027

Error:
 2016-01-18 02:31:50 URL:https://reviews.apache.org/r/42027/diff/raw/ [10981/10981] -> "42027.patch" [1]
error: patch failed: src/tests/master_quota_tests.cpp:1259
error: src/tests/master_quota_tests.cpp: patch does not apply

- Mesos ReviewBot


On Jan. 13, 2016, 3:48 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42255/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2016, 3:48 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Till Toenshoff.
> 
> 
> Bugs: MESOS-4305
>     https://issues.apache.org/jira/browse/MESOS-4305
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated user documentation around HTTP response codes.
> 
> 
> Diffs
> -----
> 
>   docs/persistent-volume.md f969975f242f7fc7a8b7a89e3e211d2201c9114a 
>   docs/reservation.md a5dbc0abd5d9aef04064dc2a1dff7eb118147e43 
> 
> Diff: https://reviews.apache.org/r/42255/diff/
> 
> 
> Testing
> -------
> 
> None: not a functional change.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>