You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by Graeme-Miller <gi...@git.apache.org> on 2015/09/02 12:06:58 UTC

[GitHub] incubator-brooklyn pull request: Update documentation

GitHub user Graeme-Miller opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/876

    Update documentation

    Fixed 3 issues:
    * README folder structure issue
    * Javadoc typo
    * Added link to Javadoc from site

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Graeme-Miller/incubator-brooklyn Update-Documentation

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/876.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #876
    
----
commit 3bed218db0b69a2d9e47963cf08b282272a3d05c
Author: Graeme-Miller <gr...@graemes-macbook-pro.local>
Date:   2015-09-02T09:01:44Z

    README.MD quick start description update
    
    README.md previously directed users to run the app by using
    “bin/brooklyn launch”, however this should be “./brooklyn/bin/brooklyn
    launch”

commit 53030bffe122256419f941312786d1d08279a24a
Author: Graeme-Miller <gr...@graemes-macbook-pro.local>
Date:   2015-09-02T09:09:44Z

    Updated AutoScalerPolicy Javadoc
    
    Corrected a typo

commit 40789074cb3fd64051ba39f4a207769f3a7ffdd1
Author: Graeme-Miller <gr...@graemes-macbook-pro.local>
Date:   2015-09-02T09:10:56Z

    Added link on DEVELOPER GUIDE page to Javadoc

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Update documentation

Posted by ahgittin <gi...@git.apache.org>.

Github user ahgittin commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/876#issuecomment-137055440
  
    All looks good.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Update documentation

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-brooklyn/pull/876


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Update documentation

Posted by ahgittin <gi...@git.apache.org>.

Github user ahgittin commented on a diff in the pull request:

https://github.com/apache/incubator-brooklyn/pull/876#discussion_r38525625

--- Diff: README.md ---
@@ -45,9 +45,8 @@ Alternatively, use Brooklyn as an integrated-stand-alone management node for you
Three quick start options are available:

* The [getting started guide](https://brooklyn.incubator.apache.org/v/latest/start/running.html) will step you through downloading and installing Brooklyn and running the examples.
-* Alternatively, [download the latest release](https://github.com/brooklyncentral/brooklyn/tarball/master) (tgz),
-* or, fork or clone the repo: `git clone git://github.com/apache/incubator-brooklyn.git` then `cd incubator-brooklyn; mvn clean install; cd usage/dist/target/brooklyn-dist; bin/brooklyn launch`
-`.
+* Alternatively, [download the latest release](https://github.com/brooklyncentral/brooklyn/tarball/master) (tgz).
--- End diff --

Ouch! This needs to point at `apache/incubator-brooklyn/tarball/master` not `brooklyncentral/brooklyn` !!! I'll fix when I merge. Could explain why you got that weird `external-location....txt` error.

---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---