You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/09/09 14:52:16 UTC

[GitHub] [cloudstack-primate] andrijapanicsb opened a new issue #678: [BUG] With VPC - LoadBalancing tab should be hidden if the IP is alerady used for i.e. Port Forwarding or Static NAT

andrijapanicsb opened a new issue #678:
URL: https://github.com/apache/cloudstack-primate/issues/678


   In VPC, there is no preserve mode with Public IPs - and for Port Forwarding, StaticNAT and LoadBalancing - if any of these services is enabled on a single (additional) Public IP - the other 2 services/tabs/buttons should be hidden - otherwise, user will attempt to configure and get an error like below (an expected error):
   
   ![image](https://user-images.githubusercontent.com/45762285/92614774-b7d22f00-f2bc-11ea-8185-30d2bf111769.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] davidjumani edited a comment on issue #678: [BUG] With VPC - LoadBalancing tab should be hidden if the IP is already used for i.e. Port Forwarding or Static NAT

Posted by GitBox <gi...@apache.org>.

davidjumani edited a comment on issue #678:
URL: https://github.com/apache/cloudstack-primate/issues/678#issuecomment-697203929


   @utchoang It is based on the `listPortForwardingRules` and `listLoadBalancerRules` apis, while the vpcid filed indicates whether it belongs to a vpc


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] davidjumani commented on issue #678: [BUG] With VPC - LoadBalancing tab should be hidden if the IP is already used for i.e. Port Forwarding or Static NAT

Posted by GitBox <gi...@apache.org>.

davidjumani commented on issue #678:
URL: https://github.com/apache/cloudstack-primate/issues/678#issuecomment-697203929


   It is based on the `listPortForwardingRules` and `listLoadBalancerRules` apis, while the vpcid filed indicates whether it belongs to a vpc


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] andrijapanicsb commented on issue #678: [BUG] With VPC - LoadBalancing tab should be hidden if the IP is already used for i.e. Port Forwarding or Static NAT

Posted by GitBox <gi...@apache.org>.

andrijapanicsb commented on issue #678:
URL: https://github.com/apache/cloudstack-primate/issues/678#issuecomment-691976530


   that is correct only for StaticNAT @ravening - needs to be fixed also for PF or LB - I'm not sure if @davidjumani is already on it or not?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] DaanHoogland closed issue #678: [BUG] With VPC - LoadBalancing tab should be hidden if the IP is already used for i.e. Port Forwarding or Static NAT

Posted by GitBox <gi...@apache.org>.

DaanHoogland closed issue #678:
URL: https://github.com/apache/cloudstack-primate/issues/678


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] davidjumani edited a comment on issue #678: [BUG] With VPC - LoadBalancing tab should be hidden if the IP is already used for i.e. Port Forwarding or Static NAT

Posted by GitBox <gi...@apache.org>.

davidjumani edited a comment on issue #678:
URL: https://github.com/apache/cloudstack-primate/issues/678#issuecomment-692671016


   @andrijapanicsb Haven't started on it yet


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd commented on issue #678: [BUG] With VPC - LoadBalancing tab should be hidden if the IP is already used for i.e. Port Forwarding or Static NAT

Posted by GitBox <gi...@apache.org>.

rhtyd commented on issue #678:
URL: https://github.com/apache/cloudstack-primate/issues/678#issuecomment-697178990


   @andrijapanicsb can you check the behaviour against old UI? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] ravening commented on issue #678: [BUG] With VPC - LoadBalancing tab should be hidden if the IP is already used for i.e. Port Forwarding or Static NAT

Posted by GitBox <gi...@apache.org>.

ravening commented on issue #678:
URL: https://github.com/apache/cloudstack-primate/issues/678#issuecomment-691975730


   @andrijapanicsb I dont see any port forwarding or loadbalancer tab is static nat is enabled
   
   ![Screenshot 2020-09-14 at 12 50 05](https://user-images.githubusercontent.com/10645273/93077240-d2275680-f688-11ea-967a-bf1671e9bb41.png)
   
   
   If its not enabled then I see both tabs
   
   ![Screenshot 2020-09-14 at 12 50 42](https://user-images.githubusercontent.com/10645273/93077303-e703ea00-f688-11ea-9898-60570d35d641.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd commented on issue #678: [BUG] With VPC - LoadBalancing tab should be hidden if the IP is already used for i.e. Port Forwarding or Static NAT

Posted by GitBox <gi...@apache.org>.

rhtyd commented on issue #678:
URL: https://github.com/apache/cloudstack-primate/issues/678#issuecomment-697336281


   @utchoang I've created/tested the cases that you can check and fix. Here are the cases: (@andrijapanicsb appreciate if you can be more specific while filing bugs, thanks)
   
   :heavy_check_mark: Case 1 - in case of static NAT I've verified that we don't show any tabs: (old UI has same UX)
   
   ![Screenshot from 2020-09-23 18-00-38](https://user-images.githubusercontent.com/95203/94012686-c04f5d00-fdc6-11ea-967f-b30d753a68b1.png)
   
   :heavy_multiplication_x: Case 2 - VPC has LB rule, it shouldn't show firewall or PF tabs:
   
   ![Screenshot from 2020-09-23 18-03-10](https://user-images.githubusercontent.com/95203/94013134-47043a00-fdc7-11ea-9513-0c8cc9adec7a.png)
   ![Screenshot from 2020-09-23 18-04-39](https://user-images.githubusercontent.com/95203/94013142-48356700-fdc7-11ea-87a3-a28ba3c169be.png)
   
   :heavy_multiplication_x: Case 3 - VPC has PF rules, it shouldn't show firewall or LB tabs:
   ![Screenshot from 2020-09-23 18-05-28](https://user-images.githubusercontent.com/95203/94013259-72872480-fdc7-11ea-8223-024a3eb41c1c.png)
   ![Screenshot from 2020-09-23 18-05-39](https://user-images.githubusercontent.com/95203/94013261-73b85180-fdc7-11ea-90ca-cc8dbd920514.png)
   
   :heavy_check_mark: Case 4 - in case the VPC IP has no tier, PF or LB rules, we should show PF and LB tabs for VPC:
   
   ![Screenshot from 2020-09-23 18-06-38](https://user-images.githubusercontent.com/95203/94013410-a6fae080-fdc7-11ea-9e71-e08cf1f43601.png)
   ![Screenshot from 2020-09-23 18-07-36](https://user-images.githubusercontent.com/95203/94013426-afebb200-fdc7-11ea-8372-ef543bfcc1e9.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd commented on issue #678: [BUG] With VPC - LoadBalancing tab should be hidden if the IP is already used for i.e. Port Forwarding or Static NAT

Posted by GitBox <gi...@apache.org>.

rhtyd commented on issue #678:
URL: https://github.com/apache/cloudstack-primate/issues/678#issuecomment-696684821


   @davidjumani can you pick this or advise @utchoang on what/how to fix this? Thanks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd commented on issue #678: [BUG] With VPC - LoadBalancing tab should be hidden if the IP is already used for i.e. Port Forwarding or Static NAT

Posted by GitBox <gi...@apache.org>.

rhtyd commented on issue #678:
URL: https://github.com/apache/cloudstack-primate/issues/678#issuecomment-697337277


   @utchoang the real issue are only case 2 and 3; it may need tweaking here https://github.com/apache/cloudstack-primate/blob/master/src/components/view/ResourceView.vue#L115 (we may need to somehow emit and ensure this code runs, after doing the specific list APIs calls (for listing pf and lb rules) and then hide appropriately)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] davidjumani commented on issue #678: [BUG] With VPC - LoadBalancing tab should be hidden if the IP is already used for i.e. Port Forwarding or Static NAT

Posted by GitBox <gi...@apache.org>.

davidjumani commented on issue #678:
URL: https://github.com/apache/cloudstack-primate/issues/678#issuecomment-692671016


   @andrijapanicsb Havn't started on it yet


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd commented on issue #678: [BUG] With VPC - LoadBalancing tab should be hidden if the IP is already used for i.e. Port Forwarding or Static NAT

Posted by GitBox <gi...@apache.org>.

rhtyd commented on issue #678:
URL: https://github.com/apache/cloudstack-primate/issues/678#issuecomment-696684821


   @davidjumani can you pick this or advise @utchoang on what/how to fix this? Thanks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] utchoang commented on issue #678: [BUG] With VPC - LoadBalancing tab should be hidden if the IP is already used for i.e. Port Forwarding or Static NAT

Posted by GitBox <gi...@apache.org>.

utchoang commented on issue #678:
URL: https://github.com/apache/cloudstack-primate/issues/678#issuecomment-697194602


   @rhtyd @davidjumani Currently I don't know which field to rely on to hide the Load Balancer Rule or PortFowardRule tab.
   ![image](https://user-images.githubusercontent.com/13766648/93982272-3c3bac00-fdab-11ea-944e-492cc8d9c810.png)
   Or is it based on getting data from the 2 API `listPortForwardingRules` and `listLoadBalancerRules`?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] davidjumani commented on issue #678: [BUG] With VPC - LoadBalancing tab should be hidden if the IP is already used for i.e. Port Forwarding or Static NAT

Posted by GitBox <gi...@apache.org>.

davidjumani commented on issue #678:
URL: https://github.com/apache/cloudstack-primate/issues/678#issuecomment-697155944


   @utchoang I think fixing this would involve merging DetailsTab, FirewallRules, PortForwarding, LoadBalancing and VpnDetails into a single tabbed vue. Once this is done :
   1. If the resource has port forwarding / load balancing rules, the enableStaticNat button should be hidden.
   2. If it is an ip associated with a vpc network, allow adding firewall rules, and either port forwarding or load balancing rules. Hide the port forwarding tab if load balancing rules are present and vice versa


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd edited a comment on issue #678: [BUG] With VPC - LoadBalancing tab should be hidden if the IP is already used for i.e. Port Forwarding or Static NAT

Posted by GitBox <gi...@apache.org>.

rhtyd edited a comment on issue #678:
URL: https://github.com/apache/cloudstack-primate/issues/678#issuecomment-697337277


   @utchoang the real issue are only case 2 and 3; it may need tweaking here https://github.com/apache/cloudstack-primate/blob/master/src/components/view/ResourceView.vue#L115 (we may need to somehow emit and ensure this code runs, after doing the specific list APIs calls (for listing pf and lb rules) and then hide appropriately). One way could be to perform the list APIs then, disable the tab (or hide it), whichever is easier.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] andrijapanicsb commented on issue #678: [BUG] With VPC - LoadBalancing tab should be hidden if the IP is already used for i.e. Port Forwarding or Static NAT

Posted by GitBox <gi...@apache.org>.

andrijapanicsb commented on issue #678:
URL: https://github.com/apache/cloudstack-primate/issues/678#issuecomment-697418481


   > 
   > 
   > @andrijapanicsb can you check the behaviour against old UI?
   
   I did check, and went with @davidjumani in details through the old UI etc.
   This is kinda common thing to check the old UI and it's a matter of 1.5minute testing.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org