You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "chibenwa (via GitHub)" <gi...@apache.org> on 2024/12/16 11:45:55 UTC

[I] Documentation: clarify the threading model [apisix-java-plugin-runner]

chibenwa opened a new issue, #312:
URL: https://github.com/apache/apisix-java-plugin-runner/issues/312

   ### Issue description
   
   CF https://github.com/linagora/tmail-backend/issues/1247
   
   Got my ass kicked today diagnoising an unresponsive Apisix plugin when the underlying Redis is down.
   
   By instinct I pushed the team to use a non blocking apprach as it leads to better resource management.
   
   But digging more I discovered the code actually runs directly on the netty event loop. This means that **any blocking IOs would cause the plugin to stop progress**.
   
   While I'm very happy the plugin runs directly Netty (performance!) this should be better documented, and also I do believe the examples should include an asynchronous example. Most of the devs around do not have the culture to understand the danger and need strong guidance. Busy tech leaders need a clear succinct statement to orientate code review and catch defects early.
   
   I would happily propose myself to write this doc!
   
   ### Environment
   
   * your apisix-java-plugin-runner version : 4.0
   
   ### Minimal test code / Steps to reproduce the issue
   
   Code snippet: https://github.com/linagora/tmail-backend/tree/master/demo/apisix/tmail-apisix-plugin-runner
   
   Reactified version: https://github.com/linagora/tmail-backend/pull/1412
   
   ### What's the expected result?
   
   Doc and example being clear enough so that no other team ever do the mistakes mine did!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Documentation: clarify the threading model [apisix-java-plugin-runner]

Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on issue #312:
URL: https://github.com/apache/apisix-java-plugin-runner/issues/312#issuecomment-2630581555

   Merged on master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Documentation: clarify the threading model [apisix-java-plugin-runner]

Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa closed issue #312: Documentation: clarify the threading model
URL: https://github.com/apache/apisix-java-plugin-runner/issues/312


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org