You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by darchons <gi...@git.apache.org> on 2018/06/06 02:47:25 UTC
[GitHub] guacamole-client pull request #296: GUACAMOLE-470: Remove translations for "...
GitHub user darchons opened a pull request:
https://github.com/apache/guacamole-client/pull/296
GUACAMOLE-470: Remove translations for "color-scheme" enum values.
Follow-up to #289. Remove translations for the "color-scheme" enum values, because the field type is now "TEXT" and not "ENUM" anymore.
Changing the field type to "TEXT" does have the disadvantage of losing localized enum choices. Maybe it would be better to keep "color-scheme" an ENUM, and add a "custom-color-scheme" TEXT field for customized color schemes?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/darchons/guacamole-client guac-470-configurable-terminal-colors
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/guacamole-client/pull/296.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #296
----
commit 06f98afcf5446c7d83cef0aaca109b57c523f960
Author: Jim Chen <nc...@...>
Date: 2018-06-06T02:42:16Z
GUACAMOLE-470: Remove translations for "color-scheme" enum values.
Remove translations for the "color-scheme" enum values, because the
field type is now "TEXT" and not "ENUM" anymore. Changing the field type
to "TEXT" does have the disadvantage of losing localized enum choices.
Maybe it would be better to keep "color-scheme" an ENUM, and add a
"custom-color-scheme" TEXT field for customized color schemes?
----
---
[GitHub] guacamole-client pull request #296: GUACAMOLE-470: Remove translations for "...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/guacamole-client/pull/296
---