You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "Stephen Gargan (JIRA)" <ji...@apache.org> on 2010/04/19 03:06:11 UTC
[jira] Created: (CAMEL-2657) Allow multiple codecs to be added to
Netty pipeline
Allow multiple codecs to be added to Netty pipeline
---------------------------------------------------
Key: CAMEL-2657
URL: https://issues.apache.org/activemq/browse/CAMEL-2657
Project: Apache Camel
Issue Type: Bug
Affects Versions: 2.3.0
Reporter: Stephen Gargan
Priority: Minor
The current endpoint configuration only allows for the configuration of a single encoder or decoder and so does not support scenarios that require more than a single encoder or decoder e.g. protobuf handlers with a frame decoders and encoders.
The attached patch adds a couple of extra config params 'encoders' and 'decoders' that lookup lists of ChannelHandlers from the registry and adds each entry from these lists to the pipeline . The existing 'encoder' and 'decoder' params are still supported though the new params will override in the cases where both are supplied.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-2657) Allow multiple codecs to be added to
Netty pipeline
Posted by "Stephen Gargan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stephen Gargan updated CAMEL-2657:
----------------------------------
Attachment: multiple.patch
> Allow multiple codecs to be added to Netty pipeline
> ---------------------------------------------------
>
> Key: CAMEL-2657
> URL: https://issues.apache.org/activemq/browse/CAMEL-2657
> Project: Apache Camel
> Issue Type: Bug
> Affects Versions: 2.3.0
> Reporter: Stephen Gargan
> Priority: Minor
> Attachments: multiple.patch
>
>
> The current endpoint configuration only allows for the configuration of a single encoder or decoder and so does not support scenarios that require more than a single encoder or decoder e.g. protobuf handlers with a frame decoders and encoders.
> The attached patch adds a couple of extra config params 'encoders' and 'decoders' that lookup lists of ChannelHandlers from the registry and adds each entry from these lists to the pipeline . The existing 'encoder' and 'decoder' params are still supported though the new params will override in the cases where both are supplied.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CAMEL-2657) Allow multiple codecs to be added to
Netty pipeline
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen reassigned CAMEL-2657:
----------------------------------
Assignee: Claus Ibsen
> Allow multiple codecs to be added to Netty pipeline
> ---------------------------------------------------
>
> Key: CAMEL-2657
> URL: https://issues.apache.org/activemq/browse/CAMEL-2657
> Project: Apache Camel
> Issue Type: Bug
> Affects Versions: 2.3.0
> Reporter: Stephen Gargan
> Assignee: Claus Ibsen
> Priority: Minor
> Attachments: multiple.patch
>
>
> The current endpoint configuration only allows for the configuration of a single encoder or decoder and so does not support scenarios that require more than a single encoder or decoder e.g. protobuf handlers with a frame decoders and encoders.
> The attached patch adds a couple of extra config params 'encoders' and 'decoders' that lookup lists of ChannelHandlers from the registry and adds each entry from these lists to the pipeline . The existing 'encoder' and 'decoder' params are still supported though the new params will override in the cases where both are supplied.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-2657) Allow multiple codecs to be added to
Netty pipeline
Posted by "Stephen Gargan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stephen Gargan updated CAMEL-2657:
----------------------------------
Attachment: spring-codecs-lists.patch
Ignore the previous patch,use spring-codecs-lists.patch instead. Having read the wiki and seen the comment to use the comma separated list of references I went to see how that should be done. I've changed it to correctly use resolveAndRemoveReferenceListParameter.
The snippets show how to use both the csv list and a java collection. I'll update the wiki now as its working again.
> Allow multiple codecs to be added to Netty pipeline
> ---------------------------------------------------
>
> Key: CAMEL-2657
> URL: https://issues.apache.org/activemq/browse/CAMEL-2657
> Project: Apache Camel
> Issue Type: Improvement
> Affects Versions: 2.3.0
> Reporter: Stephen Gargan
> Assignee: Stephen Gargan
> Priority: Minor
> Fix For: 2.3.0
>
> Attachments: multiple.patch, netty-codecs, spring-codecs-lists.patch
>
>
> The current endpoint configuration only allows for the configuration of a single encoder or decoder and so does not support scenarios that require more than a single encoder or decoder e.g. protobuf handlers with a frame decoders and encoders.
> The attached patch adds a couple of extra config params 'encoders' and 'decoders' that lookup lists of ChannelHandlers from the registry and adds each entry from these lists to the pipeline . The existing 'encoder' and 'decoder' params are still supported though the new params will override in the cases where both are supplied.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2657) Allow multiple codecs to be added to
Netty pipeline
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=58931#action_58931 ]
Claus Ibsen commented on CAMEL-2657:
------------------------------------
trunk: 935452.
Applied patch with thanks to Stephen
The wiki pages seems to be out of order in terms of updating, so we gotta do this later when wiki works again
> Allow multiple codecs to be added to Netty pipeline
> ---------------------------------------------------
>
> Key: CAMEL-2657
> URL: https://issues.apache.org/activemq/browse/CAMEL-2657
> Project: Apache Camel
> Issue Type: Bug
> Affects Versions: 2.3.0
> Reporter: Stephen Gargan
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 2.3.0
>
> Attachments: multiple.patch
>
>
> The current endpoint configuration only allows for the configuration of a single encoder or decoder and so does not support scenarios that require more than a single encoder or decoder e.g. protobuf handlers with a frame decoders and encoders.
> The attached patch adds a couple of extra config params 'encoders' and 'decoders' that lookup lists of ChannelHandlers from the registry and adds each entry from these lists to the pipeline . The existing 'encoder' and 'decoder' params are still supported though the new params will override in the cases where both are supplied.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-2657) Allow multiple codecs to be added to
Netty pipeline
Posted by "Stephen Gargan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stephen Gargan updated CAMEL-2657:
----------------------------------
Attachment: spring-codecs.patch
netty-codecs
I've attached a test that uses spring to define the encoder and decoder lists. The wiki is not working for me so I'll upload the wiki comments here for now and will add them once its back up again.
> Allow multiple codecs to be added to Netty pipeline
> ---------------------------------------------------
>
> Key: CAMEL-2657
> URL: https://issues.apache.org/activemq/browse/CAMEL-2657
> Project: Apache Camel
> Issue Type: Improvement
> Affects Versions: 2.3.0
> Reporter: Stephen Gargan
> Assignee: Stephen Gargan
> Priority: Minor
> Fix For: 2.3.0
>
> Attachments: multiple.patch, netty-codecs, spring-codecs.patch
>
>
> The current endpoint configuration only allows for the configuration of a single encoder or decoder and so does not support scenarios that require more than a single encoder or decoder e.g. protobuf handlers with a frame decoders and encoders.
> The attached patch adds a couple of extra config params 'encoders' and 'decoders' that lookup lists of ChannelHandlers from the registry and adds each entry from these lists to the pipeline . The existing 'encoder' and 'decoder' params are still supported though the new params will override in the cases where both are supplied.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CAMEL-2657) Allow multiple codecs to be added to
Netty pipeline
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen resolved CAMEL-2657.
--------------------------------
Resolution: Fixed
Thanks Stephen I have applied the latest patch to trunk
> Allow multiple codecs to be added to Netty pipeline
> ---------------------------------------------------
>
> Key: CAMEL-2657
> URL: https://issues.apache.org/activemq/browse/CAMEL-2657
> Project: Apache Camel
> Issue Type: Improvement
> Affects Versions: 2.3.0
> Reporter: Stephen Gargan
> Assignee: Stephen Gargan
> Priority: Minor
> Fix For: 2.3.0
>
> Attachments: multiple.patch, netty-codecs, spring-codecs-lists.patch
>
>
> The current endpoint configuration only allows for the configuration of a single encoder or decoder and so does not support scenarios that require more than a single encoder or decoder e.g. protobuf handlers with a frame decoders and encoders.
> The attached patch adds a couple of extra config params 'encoders' and 'decoders' that lookup lists of ChannelHandlers from the registry and adds each entry from these lists to the pipeline . The existing 'encoder' and 'decoder' params are still supported though the new params will override in the cases where both are supplied.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2657) Allow multiple codecs to be added to
Netty pipeline
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=58996#action_58996 ]
Claus Ibsen commented on CAMEL-2657:
------------------------------------
Stephen the wiki pages works again
I would be cool if you had to the time create a single example how to use {{encoders}} and {{decorders}}. And have the values been looked up in the Registry. For example in Spring XML as many people use.
https://cwiki.apache.org/confluence/display/CAMEL/Netty
> Allow multiple codecs to be added to Netty pipeline
> ---------------------------------------------------
>
> Key: CAMEL-2657
> URL: https://issues.apache.org/activemq/browse/CAMEL-2657
> Project: Apache Camel
> Issue Type: Improvement
> Affects Versions: 2.3.0
> Reporter: Stephen Gargan
> Assignee: Stephen Gargan
> Priority: Minor
> Fix For: 2.3.0
>
> Attachments: multiple.patch
>
>
> The current endpoint configuration only allows for the configuration of a single encoder or decoder and so does not support scenarios that require more than a single encoder or decoder e.g. protobuf handlers with a frame decoders and encoders.
> The attached patch adds a couple of extra config params 'encoders' and 'decoders' that lookup lists of ChannelHandlers from the registry and adds each entry from these lists to the pipeline . The existing 'encoder' and 'decoder' params are still supported though the new params will override in the cases where both are supplied.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-2657) Allow multiple codecs to be added to
Netty pipeline
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen updated CAMEL-2657:
-------------------------------
Issue Type: Improvement (was: Bug)
Assignee: Stephen Gargan (was: Claus Ibsen)
Fix Version/s: 2.3.0
> Allow multiple codecs to be added to Netty pipeline
> ---------------------------------------------------
>
> Key: CAMEL-2657
> URL: https://issues.apache.org/activemq/browse/CAMEL-2657
> Project: Apache Camel
> Issue Type: Improvement
> Affects Versions: 2.3.0
> Reporter: Stephen Gargan
> Assignee: Stephen Gargan
> Priority: Minor
> Fix For: 2.3.0
>
> Attachments: multiple.patch
>
>
> The current endpoint configuration only allows for the configuration of a single encoder or decoder and so does not support scenarios that require more than a single encoder or decoder e.g. protobuf handlers with a frame decoders and encoders.
> The attached patch adds a couple of extra config params 'encoders' and 'decoders' that lookup lists of ChannelHandlers from the registry and adds each entry from these lists to the pipeline . The existing 'encoder' and 'decoder' params are still supported though the new params will override in the cases where both are supplied.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-2657) Allow multiple codecs to be added to
Netty pipeline
Posted by "Stephen Gargan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stephen Gargan updated CAMEL-2657:
----------------------------------
Attachment: (was: spring-codecs.patch)
> Allow multiple codecs to be added to Netty pipeline
> ---------------------------------------------------
>
> Key: CAMEL-2657
> URL: https://issues.apache.org/activemq/browse/CAMEL-2657
> Project: Apache Camel
> Issue Type: Improvement
> Affects Versions: 2.3.0
> Reporter: Stephen Gargan
> Assignee: Stephen Gargan
> Priority: Minor
> Fix For: 2.3.0
>
> Attachments: multiple.patch, netty-codecs, spring-codecs-lists.patch
>
>
> The current endpoint configuration only allows for the configuration of a single encoder or decoder and so does not support scenarios that require more than a single encoder or decoder e.g. protobuf handlers with a frame decoders and encoders.
> The attached patch adds a couple of extra config params 'encoders' and 'decoders' that lookup lists of ChannelHandlers from the registry and adds each entry from these lists to the pipeline . The existing 'encoder' and 'decoder' params are still supported though the new params will override in the cases where both are supplied.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.