You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/29 01:44:33 UTC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #34135: [SPARK-36882][PYTHON] Support ILIKE API on Python

HyukjinKwon commented on a change in pull request #34135:
URL: https://github.com/apache/spark/pull/34135#discussion_r718085839



##########
File path: python/pyspark/sql/column.py
##########
@@ -507,6 +507,24 @@ def __iter__(self):
     >>> df.filter(df.name.like('Al%')).collect()
     [Row(age=2, name='Alice')]
     """
+    _ilike_doc = """
+    SQL ILIKE expression (case insensitive LIKE). Returns a boolean :class:`Column`
+    based on a case insensitive match.
+

Review comment:
       I know it is consistent with other places in the docs but let's add versionadded directive. I think we should add them actually for all places.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org