You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/06/01 07:48:06 UTC

[GitHub] [incubator-iotdb] HTHou commented on a change in pull request #1295: [IOTDB-729] shutdown uncessary threadpool

HTHou commented on a change in pull request #1295:
URL: https://github.com/apache/incubator-iotdb/pull/1295#discussion_r433089834



##########
File path: server/src/main/java/org/apache/iotdb/db/engine/storagegroup/StorageGroupProcessor.java
##########
@@ -1537,6 +1538,7 @@ private void upgradeTsFileResourceCallBack(TsFileResource tsFileResource) {
           }
         }
       }
+      UpgradeSevice.getINSTANCE().stop();

Review comment:
       If we need to stop UpgradeSevice after upgrading complete, I think we should also stop it if there is no file to be upgraded. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org