You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@continuum.apache.org by Emmanuel Venisse <em...@venisse.net> on 2007/01/02 16:27:58 UTC

Re: CONTINUUM-798: module discovery


Brett Porter a écrit :
> Hi Jesse,
> 
> I see you took this one a couple of months ago. It looks like a good 
> feature - is the patch a good enough start to use for now?
> 
> It was submitted by John Didion - John, are you hanging around? Are you 
> able to help get that applied and work through some of the limitations?
> 
> I'm pretty keen to see this one land :)

Me too, and it will be fix CONTINUUM-1098

Emmanuel



Re: CONTINUUM-798: module discovery

Posted by Emmanuel Venisse <em...@venisse.net>.
yes, it will be the easiest solution, but in future we'll can resolve them too if we search in the database the project with the scm url (svn_url_of current_pom/module_path), if it doesn't exist, we 
checkout the module and add it in continuum.


Brett Porter a écrit :
> fair enough, as long as we have sensible, pre-emptive error messages 
> (perhaps just a warning that module X was ignored due to invalid path).
> 
> On 04/01/2007, at 12:57 AM, Emmanuel Venisse wrote:
> 
>> Yes, we can use, it seems to be good but it won't work for modules 
>> with a relative path like ../mymodule
>>
>> Emmanuel
>>
>> Brett Porter a écrit :
>>> Great - can the patch be used as a starting point?
>>> On 03/01/2007, at 2:27 AM, Emmanuel Venisse wrote:
>>>>
>>>>
>>>> Brett Porter a écrit :
>>>>> Hi Jesse,
>>>>> I see you took this one a couple of months ago. It looks like a 
>>>>> good feature - is the patch a good enough start to use for now?
>>>>> It was submitted by John Didion - John, are you hanging around? Are 
>>>>> you able to help get that applied and work through some of the 
>>>>> limitations?
>>>>> I'm pretty keen to see this one land :)
>>>>
>>>> Me too, and it will be fix CONTINUUM-1098
>>>>
>>>> Emmanuel
>>>>
> 
> 
> 


Re: CONTINUUM-798: module discovery

Posted by Brett Porter <br...@apache.org>.
fair enough, as long as we have sensible, pre-emptive error messages  
(perhaps just a warning that module X was ignored due to invalid path).

On 04/01/2007, at 12:57 AM, Emmanuel Venisse wrote:

> Yes, we can use, it seems to be good but it won't work for modules  
> with a relative path like ../mymodule
>
> Emmanuel
>
> Brett Porter a écrit :
>> Great - can the patch be used as a starting point?
>> On 03/01/2007, at 2:27 AM, Emmanuel Venisse wrote:
>>>
>>>
>>> Brett Porter a écrit :
>>>> Hi Jesse,
>>>> I see you took this one a couple of months ago. It looks like a  
>>>> good feature - is the patch a good enough start to use for now?
>>>> It was submitted by John Didion - John, are you hanging around?  
>>>> Are you able to help get that applied and work through some of  
>>>> the limitations?
>>>> I'm pretty keen to see this one land :)
>>>
>>> Me too, and it will be fix CONTINUUM-1098
>>>
>>> Emmanuel
>>>

Re: CONTINUUM-798: module discovery

Posted by Emmanuel Venisse <em...@venisse.net>.
Yes, we can use, it seems to be good but it won't work for modules with a relative path like ../mymodule

Emmanuel

Brett Porter a écrit :
> Great - can the patch be used as a starting point?
> 
> On 03/01/2007, at 2:27 AM, Emmanuel Venisse wrote:
> 
>>
>>
>> Brett Porter a écrit :
>>> Hi Jesse,
>>> I see you took this one a couple of months ago. It looks like a good 
>>> feature - is the patch a good enough start to use for now?
>>> It was submitted by John Didion - John, are you hanging around? Are 
>>> you able to help get that applied and work through some of the 
>>> limitations?
>>> I'm pretty keen to see this one land :)
>>
>> Me too, and it will be fix CONTINUUM-1098
>>
>> Emmanuel
>>
> 
> 
> 


Re: CONTINUUM-798: module discovery

Posted by Brett Porter <br...@apache.org>.
Great - can the patch be used as a starting point?

On 03/01/2007, at 2:27 AM, Emmanuel Venisse wrote:

>
>
> Brett Porter a écrit :
>> Hi Jesse,
>> I see you took this one a couple of months ago. It looks like a  
>> good feature - is the patch a good enough start to use for now?
>> It was submitted by John Didion - John, are you hanging around?  
>> Are you able to help get that applied and work through some of the  
>> limitations?
>> I'm pretty keen to see this one land :)
>
> Me too, and it will be fix CONTINUUM-1098
>
> Emmanuel
>