You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Yongqiang He <he...@gmail.com> on 2011/10/28 20:28:45 UTC

Review Request: Support archiving for multiple partitions if the table is partitioned by multiple columns

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2595/
-----------------------------------------------------------

Review request for hive and namit jain.


Summary
-------

Support archiving for multiple partitions if the table is partitioned by multiple columns


This addresses bug HIVE-2278.
    https://issues.apache.org/jira/browse/HIVE-2278


Diffs
-----

  trunk/data/files/archive_corrupt.rc UNKNOWN 
  trunk/metastore/if/hive_metastore.thrift 1188906 
  trunk/metastore/src/gen/thrift/gen-cpp/hive_metastore_constants.h 1188906 
  trunk/metastore/src/gen/thrift/gen-cpp/hive_metastore_constants.cpp 1188906 
  trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Constants.java 1188906 
  trunk/metastore/src/gen/thrift/gen-php/hive_metastore/hive_metastore_constants.php 1188906 
  trunk/metastore/src/gen/thrift/gen-py/hive_metastore/constants.py 1188906 
  trunk/metastore/src/gen/thrift/gen-rb/hive_metastore_constants.rb 1188906 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java 1188906 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ArchiveUtils.java PRE-CREATION 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1188906 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1188906 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/lockmgr/zookeeper/ZooKeeperHiveLockManager.java 1188906 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/DummyPartition.java 1188906 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 1188906 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 1188906 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 1188906 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1188906 
  trunk/ql/src/test/queries/clientnegative/archive_insert1.q PRE-CREATION 
  trunk/ql/src/test/queries/clientnegative/archive_insert2.q PRE-CREATION 
  trunk/ql/src/test/queries/clientnegative/archive_insert3.q PRE-CREATION 
  trunk/ql/src/test/queries/clientnegative/archive_insert4.q PRE-CREATION 
  trunk/ql/src/test/queries/clientnegative/archive_multi1.q PRE-CREATION 
  trunk/ql/src/test/queries/clientnegative/archive_multi2.q PRE-CREATION 
  trunk/ql/src/test/queries/clientnegative/archive_multi3.q PRE-CREATION 
  trunk/ql/src/test/queries/clientnegative/archive_multi4.q PRE-CREATION 
  trunk/ql/src/test/queries/clientnegative/archive_multi5.q PRE-CREATION 
  trunk/ql/src/test/queries/clientnegative/archive_multi6.q PRE-CREATION 
  trunk/ql/src/test/queries/clientnegative/archive_multi7.q PRE-CREATION 
  trunk/ql/src/test/queries/clientnegative/archive_partspec1.q PRE-CREATION 
  trunk/ql/src/test/queries/clientnegative/archive_partspec2.q PRE-CREATION 
  trunk/ql/src/test/queries/clientnegative/archive_partspec3.q PRE-CREATION 
  trunk/ql/src/test/queries/clientpositive/archive_corrupt.q PRE-CREATION 
  trunk/ql/src/test/queries/clientpositive/archive_multi.q PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/archive1.q.out 1188906 
  trunk/ql/src/test/results/clientnegative/archive2.q.out 1188906 
  trunk/ql/src/test/results/clientnegative/archive_insert1.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/archive_insert2.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/archive_insert3.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/archive_insert4.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/archive_multi1.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/archive_multi2.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/archive_multi3.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/archive_multi4.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/archive_multi5.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/archive_multi6.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/archive_multi7.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/archive_partspec1.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/archive_partspec2.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/archive_partspec3.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientpositive/archive_corrupt.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientpositive/archive_multi.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/2595/diff


Testing
-------

Support archiving for multiple partitions if the table is partitioned by multiple columns


Thanks,

Yongqiang


Re: Review Request: Support archiving for multiple partitions if the table is partitioned by multiple columns

Posted by namit jain <nj...@fb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2595/#review2915
-----------------------------------------------------------


what happens to external tables ?

If TabAExt/ds=1 points to /WH/TabA/ds=1, and we archive TabA (ds=1),
isn't TabAExt also getting ruined ? Or, is it the burden of the owner of the
external table to fix the location of TabA (ds=1)


trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ArchiveUtils.java
<https://reviews.apache.org/r/2595/#comment6517>

    wrong comment



trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ArchiveUtils.java
<https://reviews.apache.org/r/2595/#comment6518>

    what happens if the order of columns in partSpec is wrong



trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java
<https://reviews.apache.org/r/2595/#comment6516>

    This logic looks wrong - dont you need to check the
    order of columns etc.


- namit


On 2011-10-28 18:28:45, Yongqiang He wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2595/
> -----------------------------------------------------------
> 
> (Updated 2011-10-28 18:28:45)
> 
> 
> Review request for hive and namit jain.
> 
> 
> Summary
> -------
> 
> Support archiving for multiple partitions if the table is partitioned by multiple columns
> 
> 
> This addresses bug HIVE-2278.
>     https://issues.apache.org/jira/browse/HIVE-2278
> 
> 
> Diffs
> -----
> 
>   trunk/data/files/archive_corrupt.rc UNKNOWN 
>   trunk/metastore/if/hive_metastore.thrift 1188906 
>   trunk/metastore/src/gen/thrift/gen-cpp/hive_metastore_constants.h 1188906 
>   trunk/metastore/src/gen/thrift/gen-cpp/hive_metastore_constants.cpp 1188906 
>   trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Constants.java 1188906 
>   trunk/metastore/src/gen/thrift/gen-php/hive_metastore/hive_metastore_constants.php 1188906 
>   trunk/metastore/src/gen/thrift/gen-py/hive_metastore/constants.py 1188906 
>   trunk/metastore/src/gen/thrift/gen-rb/hive_metastore_constants.rb 1188906 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java 1188906 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ArchiveUtils.java PRE-CREATION 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1188906 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1188906 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/lockmgr/zookeeper/ZooKeeperHiveLockManager.java 1188906 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/DummyPartition.java 1188906 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 1188906 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 1188906 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 1188906 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1188906 
>   trunk/ql/src/test/queries/clientnegative/archive_insert1.q PRE-CREATION 
>   trunk/ql/src/test/queries/clientnegative/archive_insert2.q PRE-CREATION 
>   trunk/ql/src/test/queries/clientnegative/archive_insert3.q PRE-CREATION 
>   trunk/ql/src/test/queries/clientnegative/archive_insert4.q PRE-CREATION 
>   trunk/ql/src/test/queries/clientnegative/archive_multi1.q PRE-CREATION 
>   trunk/ql/src/test/queries/clientnegative/archive_multi2.q PRE-CREATION 
>   trunk/ql/src/test/queries/clientnegative/archive_multi3.q PRE-CREATION 
>   trunk/ql/src/test/queries/clientnegative/archive_multi4.q PRE-CREATION 
>   trunk/ql/src/test/queries/clientnegative/archive_multi5.q PRE-CREATION 
>   trunk/ql/src/test/queries/clientnegative/archive_multi6.q PRE-CREATION 
>   trunk/ql/src/test/queries/clientnegative/archive_multi7.q PRE-CREATION 
>   trunk/ql/src/test/queries/clientnegative/archive_partspec1.q PRE-CREATION 
>   trunk/ql/src/test/queries/clientnegative/archive_partspec2.q PRE-CREATION 
>   trunk/ql/src/test/queries/clientnegative/archive_partspec3.q PRE-CREATION 
>   trunk/ql/src/test/queries/clientpositive/archive_corrupt.q PRE-CREATION 
>   trunk/ql/src/test/queries/clientpositive/archive_multi.q PRE-CREATION 
>   trunk/ql/src/test/results/clientnegative/archive1.q.out 1188906 
>   trunk/ql/src/test/results/clientnegative/archive2.q.out 1188906 
>   trunk/ql/src/test/results/clientnegative/archive_insert1.q.out PRE-CREATION 
>   trunk/ql/src/test/results/clientnegative/archive_insert2.q.out PRE-CREATION 
>   trunk/ql/src/test/results/clientnegative/archive_insert3.q.out PRE-CREATION 
>   trunk/ql/src/test/results/clientnegative/archive_insert4.q.out PRE-CREATION 
>   trunk/ql/src/test/results/clientnegative/archive_multi1.q.out PRE-CREATION 
>   trunk/ql/src/test/results/clientnegative/archive_multi2.q.out PRE-CREATION 
>   trunk/ql/src/test/results/clientnegative/archive_multi3.q.out PRE-CREATION 
>   trunk/ql/src/test/results/clientnegative/archive_multi4.q.out PRE-CREATION 
>   trunk/ql/src/test/results/clientnegative/archive_multi5.q.out PRE-CREATION 
>   trunk/ql/src/test/results/clientnegative/archive_multi6.q.out PRE-CREATION 
>   trunk/ql/src/test/results/clientnegative/archive_multi7.q.out PRE-CREATION 
>   trunk/ql/src/test/results/clientnegative/archive_partspec1.q.out PRE-CREATION 
>   trunk/ql/src/test/results/clientnegative/archive_partspec2.q.out PRE-CREATION 
>   trunk/ql/src/test/results/clientnegative/archive_partspec3.q.out PRE-CREATION 
>   trunk/ql/src/test/results/clientpositive/archive_corrupt.q.out PRE-CREATION 
>   trunk/ql/src/test/results/clientpositive/archive_multi.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/2595/diff
> 
> 
> Testing
> -------
> 
> Support archiving for multiple partitions if the table is partitioned by multiple columns
> 
> 
> Thanks,
> 
> Yongqiang
> 
>


Re: Review Request: Support archiving for multiple partitions if the table is partitioned by multiple columns

Posted by namit jain <nj...@fb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2595/#review2918
-----------------------------------------------------------



trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ArchiveUtils.java
<https://reviews.apache.org/r/2595/#comment6526>

    In the example above, (hr='1', ds='2011-01-01') will work. It should not work - it would be simpler if you check the order also



trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ArchiveUtils.java
<https://reviews.apache.org/r/2595/#comment6527>

    add some comments



trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ArchiveUtils.java
<https://reviews.apache.org/r/2595/#comment6528>

    1 for loop instead of 2 for loops



trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ArchiveUtils.java
<https://reviews.apache.org/r/2595/#comment6529>

    I think there is a bug here - not sure
    
    Why have a for loop - you are returning inside if anyway the first time ?


- namit


On 2011-10-28 18:28:45, Yongqiang He wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2595/
> -----------------------------------------------------------
> 
> (Updated 2011-10-28 18:28:45)
> 
> 
> Review request for hive and namit jain.
> 
> 
> Summary
> -------
> 
> Support archiving for multiple partitions if the table is partitioned by multiple columns
> 
> 
> This addresses bug HIVE-2278.
>     https://issues.apache.org/jira/browse/HIVE-2278
> 
> 
> Diffs
> -----
> 
>   trunk/data/files/archive_corrupt.rc UNKNOWN 
>   trunk/metastore/if/hive_metastore.thrift 1188906 
>   trunk/metastore/src/gen/thrift/gen-cpp/hive_metastore_constants.h 1188906 
>   trunk/metastore/src/gen/thrift/gen-cpp/hive_metastore_constants.cpp 1188906 
>   trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Constants.java 1188906 
>   trunk/metastore/src/gen/thrift/gen-php/hive_metastore/hive_metastore_constants.php 1188906 
>   trunk/metastore/src/gen/thrift/gen-py/hive_metastore/constants.py 1188906 
>   trunk/metastore/src/gen/thrift/gen-rb/hive_metastore_constants.rb 1188906 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java 1188906 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ArchiveUtils.java PRE-CREATION 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1188906 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1188906 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/lockmgr/zookeeper/ZooKeeperHiveLockManager.java 1188906 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/DummyPartition.java 1188906 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 1188906 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 1188906 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 1188906 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1188906 
>   trunk/ql/src/test/queries/clientnegative/archive_insert1.q PRE-CREATION 
>   trunk/ql/src/test/queries/clientnegative/archive_insert2.q PRE-CREATION 
>   trunk/ql/src/test/queries/clientnegative/archive_insert3.q PRE-CREATION 
>   trunk/ql/src/test/queries/clientnegative/archive_insert4.q PRE-CREATION 
>   trunk/ql/src/test/queries/clientnegative/archive_multi1.q PRE-CREATION 
>   trunk/ql/src/test/queries/clientnegative/archive_multi2.q PRE-CREATION 
>   trunk/ql/src/test/queries/clientnegative/archive_multi3.q PRE-CREATION 
>   trunk/ql/src/test/queries/clientnegative/archive_multi4.q PRE-CREATION 
>   trunk/ql/src/test/queries/clientnegative/archive_multi5.q PRE-CREATION 
>   trunk/ql/src/test/queries/clientnegative/archive_multi6.q PRE-CREATION 
>   trunk/ql/src/test/queries/clientnegative/archive_multi7.q PRE-CREATION 
>   trunk/ql/src/test/queries/clientnegative/archive_partspec1.q PRE-CREATION 
>   trunk/ql/src/test/queries/clientnegative/archive_partspec2.q PRE-CREATION 
>   trunk/ql/src/test/queries/clientnegative/archive_partspec3.q PRE-CREATION 
>   trunk/ql/src/test/queries/clientpositive/archive_corrupt.q PRE-CREATION 
>   trunk/ql/src/test/queries/clientpositive/archive_multi.q PRE-CREATION 
>   trunk/ql/src/test/results/clientnegative/archive1.q.out 1188906 
>   trunk/ql/src/test/results/clientnegative/archive2.q.out 1188906 
>   trunk/ql/src/test/results/clientnegative/archive_insert1.q.out PRE-CREATION 
>   trunk/ql/src/test/results/clientnegative/archive_insert2.q.out PRE-CREATION 
>   trunk/ql/src/test/results/clientnegative/archive_insert3.q.out PRE-CREATION 
>   trunk/ql/src/test/results/clientnegative/archive_insert4.q.out PRE-CREATION 
>   trunk/ql/src/test/results/clientnegative/archive_multi1.q.out PRE-CREATION 
>   trunk/ql/src/test/results/clientnegative/archive_multi2.q.out PRE-CREATION 
>   trunk/ql/src/test/results/clientnegative/archive_multi3.q.out PRE-CREATION 
>   trunk/ql/src/test/results/clientnegative/archive_multi4.q.out PRE-CREATION 
>   trunk/ql/src/test/results/clientnegative/archive_multi5.q.out PRE-CREATION 
>   trunk/ql/src/test/results/clientnegative/archive_multi6.q.out PRE-CREATION 
>   trunk/ql/src/test/results/clientnegative/archive_multi7.q.out PRE-CREATION 
>   trunk/ql/src/test/results/clientnegative/archive_partspec1.q.out PRE-CREATION 
>   trunk/ql/src/test/results/clientnegative/archive_partspec2.q.out PRE-CREATION 
>   trunk/ql/src/test/results/clientnegative/archive_partspec3.q.out PRE-CREATION 
>   trunk/ql/src/test/results/clientpositive/archive_corrupt.q.out PRE-CREATION 
>   trunk/ql/src/test/results/clientpositive/archive_multi.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/2595/diff
> 
> 
> Testing
> -------
> 
> Support archiving for multiple partitions if the table is partitioned by multiple columns
> 
> 
> Thanks,
> 
> Yongqiang
> 
>


Re: Review Request: Support archiving for multiple partitions if the table is partitioned by multiple columns

Posted by Yongqiang He <he...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2595/
-----------------------------------------------------------

(Updated 2011-10-30 07:34:36.866186)


Review request for hive and namit jain.


Changes
-------

Address review comments except the last one:
"Why have a for loop - you are returning inside if anyway the first time ?"

I think it is safe to return even for the first time. For any partition returned, it should either be archived or not. If the archive is based on its parent partition col, the partition should also be marked as archived, otherwise, it should not be there.


Summary
-------

Support archiving for multiple partitions if the table is partitioned by multiple columns


This addresses bug HIVE-2278.
    https://issues.apache.org/jira/browse/HIVE-2278


Diffs (updated)
-----

  trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java 1190490 
  trunk/metastore/src/gen/thrift/gen-rb/hive_metastore_constants.rb 1190490 
  trunk/metastore/src/gen/thrift/gen-php/hive_metastore/hive_metastore_constants.php 1190490 
  trunk/metastore/src/gen/thrift/gen-py/hive_metastore/constants.py 1190490 
  trunk/data/files/archive_corrupt.rc UNKNOWN 
  trunk/metastore/if/hive_metastore.thrift 1190490 
  trunk/metastore/src/gen/thrift/gen-cpp/hive_metastore_constants.h 1190490 
  trunk/metastore/src/gen/thrift/gen-cpp/hive_metastore_constants.cpp 1190490 
  trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Constants.java 1190490 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ArchiveUtils.java PRE-CREATION 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1190490 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1190490 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/lockmgr/zookeeper/ZooKeeperHiveLockManager.java 1190490 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/DummyPartition.java 1190490 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 1190490 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 1190490 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 1195116 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 1190490 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1190490 
  trunk/ql/src/test/queries/clientnegative/archive_insert1.q PRE-CREATION 
  trunk/ql/src/test/queries/clientnegative/archive_insert2.q PRE-CREATION 
  trunk/ql/src/test/queries/clientnegative/archive_insert3.q PRE-CREATION 
  trunk/ql/src/test/queries/clientnegative/archive_insert4.q PRE-CREATION 
  trunk/ql/src/test/queries/clientnegative/archive_multi1.q PRE-CREATION 
  trunk/ql/src/test/queries/clientnegative/archive_multi2.q PRE-CREATION 
  trunk/ql/src/test/queries/clientnegative/archive_multi3.q PRE-CREATION 
  trunk/ql/src/test/queries/clientnegative/archive_multi4.q PRE-CREATION 
  trunk/ql/src/test/queries/clientnegative/archive_multi5.q PRE-CREATION 
  trunk/ql/src/test/queries/clientnegative/archive_multi6.q PRE-CREATION 
  trunk/ql/src/test/queries/clientnegative/archive_multi7.q PRE-CREATION 
  trunk/ql/src/test/queries/clientnegative/archive_partspec1.q PRE-CREATION 
  trunk/ql/src/test/queries/clientnegative/archive_partspec2.q PRE-CREATION 
  trunk/ql/src/test/queries/clientnegative/archive_partspec3.q PRE-CREATION 
  trunk/ql/src/test/queries/clientnegative/archive_partspec4.q PRE-CREATION 
  trunk/ql/src/test/queries/clientnegative/archive_partspec5.q PRE-CREATION 
  trunk/ql/src/test/queries/clientpositive/archive_corrupt.q PRE-CREATION 
  trunk/ql/src/test/queries/clientpositive/archive_multi.q PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/archive1.q.out 1190490 
  trunk/ql/src/test/results/clientnegative/archive2.q.out 1190490 
  trunk/ql/src/test/results/clientnegative/archive_insert1.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/archive_insert2.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/archive_insert3.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/archive_insert4.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/archive_multi1.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/archive_multi2.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/archive_multi3.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/archive_multi4.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/archive_multi5.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/archive_multi6.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/archive_multi7.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/archive_partspec1.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/archive_partspec2.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/archive_partspec3.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/archive_partspec4.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/archive_partspec5.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientpositive/archive_corrupt.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientpositive/archive_multi.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/2595/diff


Testing
-------

Support archiving for multiple partitions if the table is partitioned by multiple columns


Thanks,

Yongqiang