You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Justin Edelson (JIRA)" <ji...@apache.org> on 2010/08/20 18:30:17 UTC

[jira] Created: (SLING-1675) BundleResourceProvider doesn't provide resources when asked to list the children of a mapped path

BundleResourceProvider doesn't provide resources when asked to list the children of a mapped path
-------------------------------------------------------------------------------------------------

                 Key: SLING-1675
                 URL: https://issues.apache.org/jira/browse/SLING-1675
             Project: Sling
          Issue Type: Bug
          Components: Extensions
            Reporter: Justin Edelson


If you have
<Sling-Bundle-Resources>/foo/bar</Sling-Bundle-Resources>

and the resource at "/foo" exists (say, provided by the JCR Resource Provider), then a call to BundleResourceProvider.listChildren(resource) where the resource is an existing resource at "/foo", then BRP should return an iterator over the root bundle resource (i.e. /foo/bar in this case).

This is similar to SLING-1672 with the difference being that /foo/bar is a legitimate bundle resource, whereas SLING-1672 is about having BRP provide a resource in listChildren() which it will not in getResource().

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SLING-1675) BundleResourceProvider doesn't provide resources when asked to list the children of a mapped path

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Meschberger resolved SLING-1675.
--------------------------------------

    Resolution: Won't Fix

Given that SLING-1672 really fixes the problem at the correct level, we can resolve this issue as won't fix.

> BundleResourceProvider doesn't provide resources when asked to list the children of a mapped path
> -------------------------------------------------------------------------------------------------
>
>                 Key: SLING-1675
>                 URL: https://issues.apache.org/jira/browse/SLING-1675
>             Project: Sling
>          Issue Type: Bug
>          Components: Extensions
>            Reporter: Justin Edelson
>            Assignee: Felix Meschberger
>
> If you have
> <Sling-Bundle-Resources>/foo/bar</Sling-Bundle-Resources>
> and the resource at "/foo" exists (say, provided by the JCR Resource Provider), then a call to BundleResourceProvider.listChildren(resource) where the resource is an existing resource at "/foo", then BRP should return an iterator over the root bundle resource (i.e. /foo/bar in this case).
> This is similar to SLING-1672 with the difference being that /foo/bar is a legitimate bundle resource, whereas SLING-1672 is about having BRP provide a resource in listChildren() which it will not in getResource().

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (SLING-1675) BundleResourceProvider doesn't provide resources when asked to list the children of a mapped path

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Meschberger reassigned SLING-1675:
----------------------------------------

    Assignee: Felix Meschberger

> BundleResourceProvider doesn't provide resources when asked to list the children of a mapped path
> -------------------------------------------------------------------------------------------------
>
>                 Key: SLING-1675
>                 URL: https://issues.apache.org/jira/browse/SLING-1675
>             Project: Sling
>          Issue Type: Bug
>          Components: Extensions
>            Reporter: Justin Edelson
>            Assignee: Felix Meschberger
>
> If you have
> <Sling-Bundle-Resources>/foo/bar</Sling-Bundle-Resources>
> and the resource at "/foo" exists (say, provided by the JCR Resource Provider), then a call to BundleResourceProvider.listChildren(resource) where the resource is an existing resource at "/foo", then BRP should return an iterator over the root bundle resource (i.e. /foo/bar in this case).
> This is similar to SLING-1672 with the difference being that /foo/bar is a legitimate bundle resource, whereas SLING-1672 is about having BRP provide a resource in listChildren() which it will not in getResource().

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SLING-1675) BundleResourceProvider doesn't provide resources when asked to list the children of a mapped path

Posted by "Justin Edelson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SLING-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12900760#action_12900760 ] 

Justin Edelson commented on SLING-1675:
---------------------------------------

patch for this at http://codereview.appspot.com/2000042

but I have doubts if this is a good idea.

> BundleResourceProvider doesn't provide resources when asked to list the children of a mapped path
> -------------------------------------------------------------------------------------------------
>
>                 Key: SLING-1675
>                 URL: https://issues.apache.org/jira/browse/SLING-1675
>             Project: Sling
>          Issue Type: Bug
>          Components: Extensions
>            Reporter: Justin Edelson
>
> If you have
> <Sling-Bundle-Resources>/foo/bar</Sling-Bundle-Resources>
> and the resource at "/foo" exists (say, provided by the JCR Resource Provider), then a call to BundleResourceProvider.listChildren(resource) where the resource is an existing resource at "/foo", then BRP should return an iterator over the root bundle resource (i.e. /foo/bar in this case).
> This is similar to SLING-1672 with the difference being that /foo/bar is a legitimate bundle resource, whereas SLING-1672 is about having BRP provide a resource in listChildren() which it will not in getResource().

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SLING-1675) BundleResourceProvider doesn't provide resources when asked to list the children of a mapped path

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SLING-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904986#action_12904986 ] 

Felix Meschberger commented on SLING-1675:
------------------------------------------

With the changes of SLING-1672 together with the previous refactoring of resource provider maintenance the situation has changed.

Now the BundleResourceProvider is registered at the /foo/bar node in the resource provider tree. When listing the children of /foo, the resolver asks the BundleResourceProvider (getResource-style) for the resource /foo/bar. If the provider has the resource it is returned as part of the child resource iterator for /foo. Otherwise a synthetic resource /foo/bar is returned.

Only when asking for the children of /foo/bar will the BundleResourceProvider actually be asked for the children by calling the ResourceProvider.listChildren method.

> BundleResourceProvider doesn't provide resources when asked to list the children of a mapped path
> -------------------------------------------------------------------------------------------------
>
>                 Key: SLING-1675
>                 URL: https://issues.apache.org/jira/browse/SLING-1675
>             Project: Sling
>          Issue Type: Bug
>          Components: Extensions
>            Reporter: Justin Edelson
>
> If you have
> <Sling-Bundle-Resources>/foo/bar</Sling-Bundle-Resources>
> and the resource at "/foo" exists (say, provided by the JCR Resource Provider), then a call to BundleResourceProvider.listChildren(resource) where the resource is an existing resource at "/foo", then BRP should return an iterator over the root bundle resource (i.e. /foo/bar in this case).
> This is similar to SLING-1672 with the difference being that /foo/bar is a legitimate bundle resource, whereas SLING-1672 is about having BRP provide a resource in listChildren() which it will not in getResource().

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SLING-1675) BundleResourceProvider doesn't provide resources when asked to list the children of a mapped path

Posted by "Justin Edelson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SLING-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12905021#action_12905021 ] 

Justin Edelson commented on SLING-1675:
---------------------------------------

I'm going to go ahead and apply the integration test modification from the patch. Just as soon as I make sure it passes, that is...

> BundleResourceProvider doesn't provide resources when asked to list the children of a mapped path
> -------------------------------------------------------------------------------------------------
>
>                 Key: SLING-1675
>                 URL: https://issues.apache.org/jira/browse/SLING-1675
>             Project: Sling
>          Issue Type: Bug
>          Components: Extensions
>            Reporter: Justin Edelson
>            Assignee: Felix Meschberger
>
> If you have
> <Sling-Bundle-Resources>/foo/bar</Sling-Bundle-Resources>
> and the resource at "/foo" exists (say, provided by the JCR Resource Provider), then a call to BundleResourceProvider.listChildren(resource) where the resource is an existing resource at "/foo", then BRP should return an iterator over the root bundle resource (i.e. /foo/bar in this case).
> This is similar to SLING-1672 with the difference being that /foo/bar is a legitimate bundle resource, whereas SLING-1672 is about having BRP provide a resource in listChildren() which it will not in getResource().

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.