[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #43112: [SPARK-45310][CORE] Report shuffle block status should respect shuffle service during decommission migration

["dongjoon-hyun (via GitHub)" <gi...@apache.org>]

dongjoon-hyun commented on code in PR #43112:
URL: https://github.com/apache/spark/pull/43112#discussion_r1336578008


##########
core/src/test/scala/org/apache/spark/storage/BlockManagerSuite.scala:
##########
@@ -133,12 +133,12 @@ class BlockManagerSuite extends SparkFunSuite with Matchers with PrivateMethodTe
     val bmSecurityMgr = new SecurityManager(bmConf, encryptionKey)
     val serializerManager = new SerializerManager(serializer, bmConf, encryptionKey)
     val transfer = transferService.getOrElse(new NettyBlockTransferService(
-      conf, securityMgr, serializerManager, "localhost", "localhost", 0, 1))
+      bmConf, securityMgr, serializerManager, "localhost", "localhost", 0, 1))

Review Comment:
   Is this an improvement to add a new test case or a bug, @Ngone51 ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org