You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/05/28 14:53:34 UTC

[GitHub] [hudi] Clcanny commented on a diff in pull request #5709: [MINOR] Print error msg when delta streamer config error happens

Clcanny commented on code in PR #5709:
URL: https://github.com/apache/hudi/pull/5709#discussion_r884144239


##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/UtilHelpers.java:
##########
@@ -122,6 +122,9 @@ public static Source createSource(String sourceClass, TypedProperties cfg, JavaS
                 HoodieDeltaStreamerMetrics.class},
             cfg, jssc, sparkSession, schemaProvider, metrics);
       } catch (HoodieException e) {
+        if (e.getCause() != null && !(e.getCause() instanceof NoSuchMethodException)) {
+          LOG.error("Could not load source class " + sourceClass, e);

Review Comment:
   Thanks for your review! I think we shouldn't print error msg of NoSuchMethodException, because it is noisy and user doesn't need to know that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org