Re: [PR] IGNITE-20976: Sql. Multistatement dynamic parameters adjusting works incorrect for DELETE operator. [ignite-3]

["korlov42 (via GitHub)" <gi...@apache.org>]

korlov42 commented on code in PR #2915:
URL: https://github.com/apache/ignite-3/pull/2915#discussion_r1417340558


##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/sql/SqlAlterColumnDdlParserTest.java:
##########
@@ -53,8 +46,15 @@ public class SqlAlterColumnDdlParserTest extends AbstractDdlParserTest {
      */
     @Test
     public void testNotNull() {
-        assertThat(parseAlterColumn("SET NOT NULL").notNull(), is(true));
-        assertThat(parseAlterColumn("DROP NOT NULL").notNull(), is(false));
+        IgniteSqlAlterColumn alterColumn = parseAlterColumn("ALTER TABLE t ALTER COLUMN a SET NOT NULL");
+        assertThat(alterColumn.notNull(), is(true));
+        expectUnparsed(alterColumn, "ALTER TABLE \"T\" ALTER COLUMN \"A\" SET NOT NULL");
+
+        assertThat(alterColumn.notNull(), is(true));

Review Comment:
   I see the very same check at line 50... Do we need to check it twice? 



##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/sql/IgniteSqlCreateZone.java:
##########
@@ -35,14 +35,31 @@
  * Parse tree for {@code CREATE ZONE} statement with Ignite specific features.
  */
 public class IgniteSqlCreateZone extends SqlCreate {
+
+    /** CREATE ZONE operator. */
+    protected static class Operator extends IgniteDdlOperator {
+
+        /** Constructor. */
+        protected Operator(boolean existFlag) {
+            super("ALTER ZONE", SqlKind.OTHER_DDL, existFlag);

Review Comment:
   CREATE



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org