You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/08/15 09:49:50 UTC
[GitHub] [ignite] tledkov commented on a diff in pull request #10195: IGNITE-14914 Add IndexQuery IN criterion
tledkov commented on code in PR #10195:
URL: https://github.com/apache/ignite/pull/10195#discussion_r945576543
##########
modules/core/src/main/java/org/apache/ignite/internal/cache/query/index/IndexQueryProcessor.java:
##########
@@ -615,14 +503,22 @@ private boolean rowIsOutOfRange(
List<InlineIndexKeyType> keyTypes = tree.rowHandler().inlineIndexKeyTypes();
for (int keyIdx = 0; keyIdx < criteriaKeysCnt; keyIdx++) {
- RangeIndexQueryCriterion c = qry.criteria[keyIdx];
+ RangeIndexQueryCriterion c = qry.keyCond[keyIdx].range();
+ Set<IndexKey> inVals = qry.keyCond[keyIdx].inVals();
InlineIndexKeyType keyType = keyIdx < keyTypes.size() ? keyTypes.get(keyIdx) : null;
boolean descOrder = descOrderCache[keyIdx];
int maxSize = tree.inlineSize() - fieldOff;
+ if (inVals != null) {
+ IndexRow row = io.getLookupRow(tree, pageAddr, idx);
Review Comment:
What do you think about using inline payload data if it is available for check IN condition?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org