You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/10/25 17:14:51 UTC

[GitHub] [arrow] lidavidm opened a new pull request #11536: ARROW-14174: [C++] Deduplicate some Decimal/FixedSizeBinary kernels

lidavidm opened a new pull request #11536:
URL: https://github.com/apache/arrow/pull/11536


   Now that their respective scalar classes have a common `util::string_view view() const` getter, we can use that to consolidate some kernel implementations and hopefully shave binary size/build time a little.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] lidavidm closed pull request #11536: ARROW-14174: [C++] Deduplicate some Decimal/FixedSizeBinary kernels

Posted by GitBox <gi...@apache.org>.
lidavidm closed pull request #11536:
URL: https://github.com/apache/arrow/pull/11536


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] cyb70289 edited a comment on pull request #11536: ARROW-14174: [C++] Deduplicate some Decimal/FixedSizeBinary kernels

Posted by GitBox <gi...@apache.org>.
cyb70289 edited a comment on pull request #11536:
URL: https://github.com/apache/arrow/pull/11536#issuecomment-953447473


   CI error looks not related, but may deserve deeper investigation.
   https://ci.appveyor.com/project/ApacheSoftwareFoundation/arrow/builds/41278276/job/j9k4897e9ppwt2q4#L782
   Created jira: https://issues.apache.org/jira/browse/ARROW-14494


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot edited a comment on pull request #11536: ARROW-14174: [C++] Deduplicate some Decimal/FixedSizeBinary kernels

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #11536:
URL: https://github.com/apache/arrow/pull/11536#issuecomment-954152078


   Benchmark runs are scheduled for baseline = faafc51840143635eb06957ccbb8d3669aa30c1d and contender = 2ae84e8e90a7c0d8cd37df07d69e982dcfd16eaf. 2ae84e8e90a7c0d8cd37df07d69e982dcfd16eaf is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/232e1a95874048278920e196dfeb9016...13775b715a3a4e6aa99934b70feee020/)
   [Finished :arrow_down:18.97% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/a7d2b3b6128b44f6ab2fc1148b82b8ba...547df79310fd4d8ea29e2fd6c48aef10/)
   [Finished :arrow_down:0.94% :arrow_up:0.36%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/d5ee42eef1b143319081bd49cfbeb993...71fd7c97b73a49f48951c4328a3be678/)
   Supported benchmarks:
   ursa-i9-9960x: langs = Python, R, JavaScript
   ursa-thinkcentre-m75q: langs = C++, Java
   ec2-t3-xlarge-us-east-2: cloud = True
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot edited a comment on pull request #11536: ARROW-14174: [C++] Deduplicate some Decimal/FixedSizeBinary kernels

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #11536:
URL: https://github.com/apache/arrow/pull/11536#issuecomment-954152078


   Benchmark runs are scheduled for baseline = faafc51840143635eb06957ccbb8d3669aa30c1d and contender = 2ae84e8e90a7c0d8cd37df07d69e982dcfd16eaf. 2ae84e8e90a7c0d8cd37df07d69e982dcfd16eaf is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/232e1a95874048278920e196dfeb9016...13775b715a3a4e6aa99934b70feee020/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/a7d2b3b6128b44f6ab2fc1148b82b8ba...547df79310fd4d8ea29e2fd6c48aef10/)
   [Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/d5ee42eef1b143319081bd49cfbeb993...71fd7c97b73a49f48951c4328a3be678/)
   Supported benchmarks:
   ursa-i9-9960x: langs = Python, R, JavaScript
   ursa-thinkcentre-m75q: langs = C++, Java
   ec2-t3-xlarge-us-east-2: cloud = True
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #11536: ARROW-14174: [C++] Deduplicate some Decimal/FixedSizeBinary kernels

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11536:
URL: https://github.com/apache/arrow/pull/11536#issuecomment-951134441


   https://issues.apache.org/jira/browse/ARROW-14174


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] lidavidm commented on pull request #11536: ARROW-14174: [C++] Deduplicate some Decimal/FixedSizeBinary kernels

Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #11536:
URL: https://github.com/apache/arrow/pull/11536#issuecomment-954151352


   Thanks for catching that and filing the JIRA.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot edited a comment on pull request #11536: ARROW-14174: [C++] Deduplicate some Decimal/FixedSizeBinary kernels

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #11536:
URL: https://github.com/apache/arrow/pull/11536#issuecomment-954152078






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] cyb70289 commented on pull request #11536: ARROW-14174: [C++] Deduplicate some Decimal/FixedSizeBinary kernels

Posted by GitBox <gi...@apache.org>.
cyb70289 commented on pull request #11536:
URL: https://github.com/apache/arrow/pull/11536#issuecomment-953447473


   CI error looks not related, but may deserve deeper investigation.
   https://ci.appveyor.com/project/ApacheSoftwareFoundation/arrow/builds/41278276/job/j9k4897e9ppwt2q4#L782


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot edited a comment on pull request #11536: ARROW-14174: [C++] Deduplicate some Decimal/FixedSizeBinary kernels

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #11536:
URL: https://github.com/apache/arrow/pull/11536#issuecomment-954152078


   Benchmark runs are scheduled for baseline = faafc51840143635eb06957ccbb8d3669aa30c1d and contender = 2ae84e8e90a7c0d8cd37df07d69e982dcfd16eaf. 2ae84e8e90a7c0d8cd37df07d69e982dcfd16eaf is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/232e1a95874048278920e196dfeb9016...13775b715a3a4e6aa99934b70feee020/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/a7d2b3b6128b44f6ab2fc1148b82b8ba...547df79310fd4d8ea29e2fd6c48aef10/)
   [Finished :arrow_down:0.94% :arrow_up:0.36%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/d5ee42eef1b143319081bd49cfbeb993...71fd7c97b73a49f48951c4328a3be678/)
   Supported benchmarks:
   ursa-i9-9960x: langs = Python, R, JavaScript
   ursa-thinkcentre-m75q: langs = C++, Java
   ec2-t3-xlarge-us-east-2: cloud = True
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot commented on pull request #11536: ARROW-14174: [C++] Deduplicate some Decimal/FixedSizeBinary kernels

Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #11536:
URL: https://github.com/apache/arrow/pull/11536#issuecomment-954152078


   Benchmark runs are scheduled for baseline = faafc51840143635eb06957ccbb8d3669aa30c1d and contender = 2ae84e8e90a7c0d8cd37df07d69e982dcfd16eaf. 2ae84e8e90a7c0d8cd37df07d69e982dcfd16eaf is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/232e1a95874048278920e196dfeb9016...13775b715a3a4e6aa99934b70feee020/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/a7d2b3b6128b44f6ab2fc1148b82b8ba...547df79310fd4d8ea29e2fd6c48aef10/)
   [Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/d5ee42eef1b143319081bd49cfbeb993...71fd7c97b73a49f48951c4328a3be678/)
   Supported benchmarks:
   ursa-i9-9960x: langs = Python, R, JavaScript
   ursa-thinkcentre-m75q: langs = C++, Java
   ec2-t3-xlarge-us-east-2: cloud = True
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org