[jira] [Updated] (FLINK-24706) AkkaInvocationHandler silently ignores deserialization errors

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/FLINK-24706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ASF GitHub Bot updated FLINK-24706:
-----------------------------------
    Labels: pull-request-available  (was: )

> AkkaInvocationHandler silently ignores deserialization errors
> -------------------------------------------------------------
>
>                 Key: FLINK-24706
>                 URL: https://issues.apache.org/jira/browse/FLINK-24706
>             Project: Flink
>          Issue Type: Bug
>          Components: Runtime / Coordination
>    Affects Versions: 1.13.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.15.0, 1.14.1, 1.13.4
>
>
> In AkkaInvocationHandler#invokeRpc we create a new CompletableFuture to return to the caller, and setup a forwarding routine that runs when the response is received via akka.
> {code}
> final CompletableFuture<Object> completableFuture = new CompletableFuture<>();
> resultFuture.whenComplete(
>         (resultValue, failure) -> {
>             if (failure != null) {
>                 completableFuture.completeExceptionally(
>                         resolveTimeoutException(
>                                 failure, callStackCapture, address, rpcInvocation));
>             } else {
>                 completableFuture.complete(
>                         deserializeValueIfNeeded(resultValue, method));
>             }
>         });
> {code}
> If {{deserializeValueIfNeeded}} fails then {{completableFuture}} will never be completed, and we exception will not be logged anywhere.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)