You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/04/01 16:12:50 UTC

[GitHub] [pulsar] 315157973 opened a new pull request #10121: Support set namespace and topic policy for non-persistent dispatcher

315157973 opened a new pull request #10121:
URL: https://github.com/apache/pulsar/pull/10121


   
   ### Motivation
   maxConsumerPerSubscription in NonPersistentDispatcherMultipleConsumers only support broker-level policies
   
   ### Modifications
   Make it support namespace and topic level policies
   
   ### Verifying this change
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] 315157973 commented on pull request #10121: Support set namespace and topic policy for non-persistent dispatcher

Posted by GitBox <gi...@apache.org>.
315157973 commented on pull request #10121:
URL: https://github.com/apache/pulsar/pull/10121#issuecomment-829917063


   > I would like to not cherry pick #10061 it looks to me that it is better not to introduce now refactor, now that we are close to the release
   > @codelipenghui
   
   There is a relationship between them. If we want to cherry-pick, we need to pick both of them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui commented on pull request #10121: Support set namespace and topic policy for non-persistent dispatcher

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #10121:
URL: https://github.com/apache/pulsar/pull/10121#issuecomment-829058345


   This PR depends on https://github.com/apache/pulsar/pull/10061, we need to cherry-pick #10061 first.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun commented on pull request #10121: Support set namespace and topic policy for non-persistent dispatcher

Posted by GitBox <gi...@apache.org>.
tisonkun commented on pull request #10121:
URL: https://github.com/apache/pulsar/pull/10121#issuecomment-851005632


   Hi @codelipenghui @eolivelli ! Recently I see a cherry-pick command added into pulsar bot a few months ago. I'm curious whether or not it is still in use.
   
   https://github.com/apache/pulsar-test-infra/blob/master/cherry-pick/entrypoint.sh


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli commented on pull request #10121: Support set namespace and topic policy for non-persistent dispatcher

Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #10121:
URL: https://github.com/apache/pulsar/pull/10121#issuecomment-829088145


   I would like to not cherry pick #10061 it looks to me that it is better not to introduce now refactor, now that we are close to the release
   @codelipenghui 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli commented on pull request #10121: Support set namespace and topic policy for non-persistent dispatcher

Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #10121:
URL: https://github.com/apache/pulsar/pull/10121#issuecomment-829040007


   @315157973 this patch does not apply to branch-7.2.
   Do you mind sending a PR against branch-7.2 ?
   this way we can deliver this fix in 2.7.2


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui merged pull request #10121: Support set namespace and topic policy for non-persistent dispatcher

Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #10121:
URL: https://github.com/apache/pulsar/pull/10121


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org