You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/10/27 16:01:51 UTC
[GitHub] [superset] Jolcik opened a new pull request #17252: feat: add possibility to set ingress class name in Helm chart
Jolcik opened a new pull request #17252:
URL: https://github.com/apache/superset/pull/17252
### SUMMARY
Adds the possibility to set ingress class name in Helm chart. See: #17085
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
### TESTING INSTRUCTIONS
### ADDITIONAL INFORMATION
- [x] Has associated issue: #17085
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [x] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Jolcik commented on a change in pull request #17252: feat: add possibility to set ingress class name in Helm chart
Posted by GitBox <gi...@apache.org>.
Jolcik commented on a change in pull request #17252:
URL: https://github.com/apache/superset/pull/17252#discussion_r738387254
##########
File path: helm/superset/values.yaml
##########
@@ -165,6 +165,7 @@ service:
ingress:
enabled: false
+ # ingressClassName: nginx
annotations: {}
# kubernetes.io/ingress.class: nginx
Review comment:
Right, removed the comment, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dpgaspar merged pull request #17252: feat: add possibility to set ingress class name in Helm chart
Posted by GitBox <gi...@apache.org>.
dpgaspar merged pull request #17252:
URL: https://github.com/apache/superset/pull/17252
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dpgaspar commented on a change in pull request #17252: feat: add possibility to set ingress class name in Helm chart
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #17252:
URL: https://github.com/apache/superset/pull/17252#discussion_r737948888
##########
File path: helm/superset/values.yaml
##########
@@ -165,6 +165,7 @@ service:
ingress:
enabled: false
+ # ingressClassName: nginx
annotations: {}
# kubernetes.io/ingress.class: nginx
Review comment:
If this is deprecated let's just remove the comment or add a deprecation notice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dpgaspar commented on pull request #17252: feat: add possibility to set ingress class name in Helm chart
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on pull request #17252:
URL: https://github.com/apache/superset/pull/17252#issuecomment-953886079
Thank you for the contribution @Jolcik!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org