You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/09/08 08:48:17 UTC
[GitHub] [apisix] gxthrj opened a new pull request #2185: fix: change the config file when deploying apisix in k8s #2182
gxthrj opened a new pull request #2185:
URL: https://github.com/apache/apisix/pull/2185
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [x] Have you modified the corresponding document?
* [ ] Is this PR backward compatible?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] gxthrj commented on a change in pull request #2185: fix: change the config file when deploying apisix in k8s #2182
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #2185:
URL: https://github.com/apache/apisix/pull/2185#discussion_r487748006
##########
File path: kubernetes/README.md
##########
@@ -57,11 +48,15 @@ etcd:
#### Create configmap for apache apisix
+you will change some config by use `apisix-gw-config-cm.yaml`
Review comment:
yes, you are right
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #2185: fix: change the config file when deploying apisix in k8s #2182
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #2185:
URL: https://github.com/apache/apisix/pull/2185#discussion_r487623501
##########
File path: kubernetes/README.md
##########
@@ -57,11 +48,15 @@ etcd:
#### Create configmap for apache apisix
+you will change some config by use `apisix-gw-config-cm.yaml`
Review comment:
It seems that we can always create configmap `apisix-gw-config.yaml` via `config.yaml`.
If you use the default one, you can use `config.yaml`.
If you need to change the default, you can change the `config.yaml`, so the behavior is consistent between k8s and normal installation.
By this way, we can ensure only one place hold the customized configure (for instance, only one place to change the etcd address).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #2185: fix: change the config file when deploying apisix in k8s #2182
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #2185:
URL: https://github.com/apache/apisix/pull/2185
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org