You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by "runzhiwang (Jira)" <ji...@apache.org> on 2020/04/03 08:29:00 UTC
[jira] [Comment Edited] (RATIS-836) It's a waste to send an empty
request to check leader state
[ https://issues.apache.org/jira/browse/RATIS-836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17074398#comment-17074398 ]
runzhiwang edited comment on RATIS-836 at 4/3/20, 8:28 AM:
-----------------------------------------------------------
[~ljain] Could you help review this jira again ?
was (Author: yjxxtd):
[~ljain] Could you help review it again ?
> It's a waste to send an empty request to check leader state
> -----------------------------------------------------------
>
> Key: RATIS-836
> URL: https://issues.apache.org/jira/browse/RATIS-836
> Project: Ratis
> Issue Type: Improvement
> Reporter: runzhiwang
> Priority: Major
> Attachments: screenshot-1.png
>
>
> *What's the problem ?*
> Before send [normal request|https://github.com/apache/incubator-ratis/blob/master/ratis-client/src/main/java/org/apache/ratis/client/impl/OrderedAsync.java#L243], ratis client will send an [empty request|https://github.com/apache/incubator-ratis/blob/master/ratis-client/src/main/java/org/apache/ratis/client/impl/OrderedAsync.java#L235] to server to check the leader state, which cost about 5 millseconds, it's a waste, because leader change rarely.
> *How to improve ?*
> I think it can be improved by send normal request directly to server, without sending the empty request. If the server was not leader, response client with the NotLeaderException and client retry the request. [~msingh] [~shashikant] What do you think ? If you agree with it, I will submit an PR.
> Besides one RPC call cost 5 millsecons is also weired, I will find out the root cause.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)