You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/17 08:59:22 UTC

[GitHub] [airflow] humit0 opened a new issue #20373: Paused event is logging twice in some pages.

humit0 opened a new issue #20373:
URL: https://github.com/apache/airflow/issues/20373


   ### Apache Airflow version
   
   2.2.2 (latest released)
   
   ### What happened
   
   If I pause/unpause dag in `Tree`, `Graph`, or `Gantt` page, `/paused` url is calling twice.
   
   ![image](https://user-images.githubusercontent.com/8676247/146517082-b359a81c-a53f-4aa7-a2e8-11bdbdd1e4d8.png)
   
   So paused events are logging twice.
   ![image](https://user-images.githubusercontent.com/8676247/146517366-d25efa3c-a029-4aa4-a655-60a8d84a1e1c.png)
   
   
   ### What you expected to happen
   
   It should be logging only once.
   
   ### How to reproduce
   
   Go to `Tree`, `Graph`, or `Gantt` page. And pause/unpause it.
   
   ### Operating System
   
   centos
   
   ### Versions of Apache Airflow Providers
   
   _No response_
   
   ### Deployment
   
   Other 3rd-party Helm chart
   
   ### Deployment details
   
   _No response_
   
   ### Anything else
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] humit0 commented on issue #20373: Paused event is logging twice in some pages.

Posted by GitBox <gi...@apache.org>.
humit0 commented on issue #20373:
URL: https://github.com/apache/airflow/issues/20373#issuecomment-997385761


   Maybe #15896 was similar issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] humit0 commented on issue #20373: Paused event is logging twice in some pages.

Posted by GitBox <gi...@apache.org>.
humit0 commented on issue #20373:
URL: https://github.com/apache/airflow/issues/20373#issuecomment-996600385


   @ashb yes I clicked once.
   
   There are duplicated code in `tree.[hash].js` and `dag.[hash].js`, so it call twice.
   ![image](https://user-images.githubusercontent.com/8676247/146528222-4cd8a672-eb2b-4005-870d-6702c19ac6c7.png)
   
   ![image](https://user-images.githubusercontent.com/8676247/146528284-b7790cee-b24f-4997-a82e-f4ef28af2e3c.png)
   
   So I think it needs to split [dag.js](https://github.com/apache/airflow/blob/main/airflow/www/static/js/dag.js) file.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] bbovenzi commented on issue #20373: Paused event is logging twice in some pages.

Posted by GitBox <gi...@apache.org>.
bbovenzi commented on issue #20373:
URL: https://github.com/apache/airflow/issues/20373#issuecomment-996756144


   Good catch. Looks like our webpack isn't handling es6 style `import` statements efficiently. Webpack is always annoying to deal with but we already needed to improve it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ashb commented on issue #20373: Paused event is logging twice in some pages.

Posted by GitBox <gi...@apache.org>.
ashb commented on issue #20373:
URL: https://github.com/apache/airflow/issues/20373#issuecomment-996606550


   Good digging @humit0 !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ashb commented on issue #20373: Paused event is logging twice in some pages.

Posted by GitBox <gi...@apache.org>.
ashb commented on issue #20373:
URL: https://github.com/apache/airflow/issues/20373#issuecomment-996589700


   Just to ask the obvious question first: you're not double clicking the control are you?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org