You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "dannycjones (via GitHub)" <gi...@apache.org> on 2026/06/16 09:44:08 UTC
[PR] chore(ci): add bump_msrv.py script [iceberg-rust]
dannycjones opened a new pull request, #2657:
URL: https://github.com/apache/iceberg-rust/pull/2657
## Which issue does this PR close?
N/A
## What changes are included in this PR?
I authored this script (with the assistance of an LLM) to make MSRV version bumps simple.
## Are these changes tested?
Yes, I used it to author this PR: #2652
I have tested it with and without a `GITHUB_TOKEN` and validated the error handling worked for throttling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] chore(ci): add bump_msrv.py script [iceberg-rust]
Posted by "dannycjones (via GitHub)" <gi...@apache.org>.
dannycjones closed pull request #2657: chore(ci): add bump_msrv.py script
URL: https://github.com/apache/iceberg-rust/pull/2657
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] chore(ci): add bump_msrv.py script [iceberg-rust]
Posted by "dannycjones (via GitHub)" <gi...@apache.org>.
dannycjones commented on PR #2657:
URL: https://github.com/apache/iceberg-rust/pull/2657#issuecomment-4721736215
> I'm hesitating adding this script, upgrading rust toolchain and msrv is just one line change and a simple lookup, there is no need to automate this with maintaining burden.
I share the hesitation. The script ended up being longer than expecting (and easy for GenAI to churn out) for minimal gain. It only skips the manual process of browsing the release page and picking out a good version matching the criteria.
The flip side (why I tried writing it) was to be able to add a simple script to run in the release guide and/or whenever someone wants to update MSRV. It'll cover not just the `Cargo.toml` but also the Rust toolchain used by clippy, etc.
I'm happy to close it, unless someone wants to include it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] chore(ci): add bump_msrv.py script [iceberg-rust]
Posted by "dannycjones (via GitHub)" <gi...@apache.org>.
dannycjones commented on PR #2657:
URL: https://github.com/apache/iceberg-rust/pull/2657#issuecomment-4766947784
I'll close this one out for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org