You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Sanjay Tripathi <sa...@citrix.com> on 2013/03/08 10:08:50 UTC
Review Request: CLOUDSTACK-1592: [UI] Add support to limit newly added
resourcetypes
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9816/
-----------------------------------------------------------
Review request for cloudstack, Pranav Saxena, Brian Federle, and Jessica Wang.
Description
-------
CLOUDSTACK-1592: [UI] Add support to limit newly added resourcetypes.
This is the UI implementation for limiting resources feature. This will display and update resources (CPU, Memory, Primary storage, Secondary storage space) limits in the UI.
This addresses bug CLOUDSTACK-1592.
Diffs
-----
client/WEB-INF/classes/resources/messages.properties d167a5c
ui/dictionary.jsp 3aecaaa
ui/scripts/accounts.js 3727f8e
ui/scripts/domains.js 991e37d
ui/scripts/projects.js b62dcb4
Diff: https://reviews.apache.org/r/9816/diff/
Testing
-------
Tests:
1. create a account and go to detail view, user will get the Max resource count for the new resourcetypes along with the previously added resource types.
2. create a domain and go to detail view, admin will get the details of all the resourcestypes.
3. deploy a VM, resource count will update accordingly.
Thanks,
Sanjay Tripathi
Re: Review Request: CLOUDSTACK-1592: [UI] Add support to limit newly added
resourcetypes
Posted by Pranav Saxena <pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9816/#review17604
-----------------------------------------------------------
Code changes look good to me . But I need to make sure , if the update limits API call is async in nature or not .As per your changes , the UI is passing "async" as false . Asynchronous API request methods returns immediately without blocking the calling thread.If the backend implementation just involves updating the db , then I think it's ok.
Perhaps someone in the community can comment on this aspect . Rest of the code is perfect !
Thanks !
- Pranav Saxena
On March 8, 2013, 9:08 a.m., Sanjay Tripathi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9816/
> -----------------------------------------------------------
>
> (Updated March 8, 2013, 9:08 a.m.)
>
>
> Review request for cloudstack, Pranav Saxena, Brian Federle, and Jessica Wang.
>
>
> Description
> -------
>
> CLOUDSTACK-1592: [UI] Add support to limit newly added resourcetypes.
>
> This is the UI implementation for limiting resources feature. This will display and update resources (CPU, Memory, Primary storage, Secondary storage space) limits in the UI.
>
>
> This addresses bug CLOUDSTACK-1592.
>
>
> Diffs
> -----
>
> client/WEB-INF/classes/resources/messages.properties d167a5c
> ui/dictionary.jsp 3aecaaa
> ui/scripts/accounts.js 3727f8e
> ui/scripts/domains.js 991e37d
> ui/scripts/projects.js b62dcb4
>
> Diff: https://reviews.apache.org/r/9816/diff/
>
>
> Testing
> -------
>
> Tests:
> 1. create a account and go to detail view, user will get the Max resource count for the new resourcetypes along with the previously added resource types.
> 2. create a domain and go to detail view, admin will get the details of all the resourcestypes.
> 3. deploy a VM, resource count will update accordingly.
>
>
> Thanks,
>
> Sanjay Tripathi
>
>
Re: Review Request: CLOUDSTACK-1592: [UI] Add support to limit newly added
resourcetypes
Posted by Pranav Saxena <pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9816/#review17605
-----------------------------------------------------------
Ship it!
Just had a discussion with one of the developers and passing async as false looks fine since it's just a db update operation which happens instantaneously . I'll merge the UI changes when the back-end code is checked in to master.
Thanks !
- Pranav Saxena
On March 8, 2013, 9:08 a.m., Sanjay Tripathi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9816/
> -----------------------------------------------------------
>
> (Updated March 8, 2013, 9:08 a.m.)
>
>
> Review request for cloudstack, Pranav Saxena, Brian Federle, and Jessica Wang.
>
>
> Description
> -------
>
> CLOUDSTACK-1592: [UI] Add support to limit newly added resourcetypes.
>
> This is the UI implementation for limiting resources feature. This will display and update resources (CPU, Memory, Primary storage, Secondary storage space) limits in the UI.
>
>
> This addresses bug CLOUDSTACK-1592.
>
>
> Diffs
> -----
>
> client/WEB-INF/classes/resources/messages.properties d167a5c
> ui/dictionary.jsp 3aecaaa
> ui/scripts/accounts.js 3727f8e
> ui/scripts/domains.js 991e37d
> ui/scripts/projects.js b62dcb4
>
> Diff: https://reviews.apache.org/r/9816/diff/
>
>
> Testing
> -------
>
> Tests:
> 1. create a account and go to detail view, user will get the Max resource count for the new resourcetypes along with the previously added resource types.
> 2. create a domain and go to detail view, admin will get the details of all the resourcestypes.
> 3. deploy a VM, resource count will update accordingly.
>
>
> Thanks,
>
> Sanjay Tripathi
>
>
Re: Review Request: CLOUDSTACK-1592: [UI] Add support to limit newly added
resourcetypes
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9816/#review18499
-----------------------------------------------------------
Commit 2c176ab9ea6216b7c9da25ce0b0d2b34cbc2a776 in branch refs/heads/master from Pranav Saxena <pr...@citrix.com>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=2c176ab ]
CLOUDSTACK-1592:[UI] Add support to limit newly added resourcetypes
- ASF Subversion and Git Services
On March 29, 2013, 8:35 a.m., Sanjay Tripathi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9816/
> -----------------------------------------------------------
>
> (Updated March 29, 2013, 8:35 a.m.)
>
>
> Review request for cloudstack, Pranav Saxena, Brian Federle, and Jessica Wang.
>
>
> Description
> -------
>
> CLOUDSTACK-1592: [UI] Add support to limit newly added resourcetypes.
>
> This is the UI implementation for limiting resources feature. This will display and update resources (CPU, Memory, Primary storage, Secondary storage space) limits in the UI.
>
>
> This addresses bug CLOUDSTACK-1592.
>
>
> Diffs
> -----
>
> client/WEB-INF/classes/resources/messages.properties 66b32ac
> ui/dictionary.jsp cd8d732
> ui/scripts/accounts.js 3403337
> ui/scripts/domains.js 991e37d
> ui/scripts/projects.js b62dcb4
>
> Diff: https://reviews.apache.org/r/9816/diff/
>
>
> Testing
> -------
>
> Tests:
> 1. create a account and go to detail view, user will get the Max resource count for the new resourcetypes along with the previously added resource types.
> 2. create a domain and go to detail view, admin will get the details of all the resourcestypes.
> 3. deploy a VM, resource count will update accordingly.
>
>
> Thanks,
>
> Sanjay Tripathi
>
>
Re: Review Request: CLOUDSTACK-1592: [UI] Add support to limit newly added
resourcetypes
Posted by Sanjay Tripathi <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9816/
-----------------------------------------------------------
(Updated March 29, 2013, 8:35 a.m.)
Review request for cloudstack, Pranav Saxena, Brian Federle, and Jessica Wang.
Changes
-------
Resolved conflicts with the latest code.
Description
-------
CLOUDSTACK-1592: [UI] Add support to limit newly added resourcetypes.
This is the UI implementation for limiting resources feature. This will display and update resources (CPU, Memory, Primary storage, Secondary storage space) limits in the UI.
This addresses bug CLOUDSTACK-1592.
Diffs (updated)
-----
client/WEB-INF/classes/resources/messages.properties 66b32ac
ui/dictionary.jsp cd8d732
ui/scripts/accounts.js 3403337
ui/scripts/domains.js 991e37d
ui/scripts/projects.js b62dcb4
Diff: https://reviews.apache.org/r/9816/diff/
Testing
-------
Tests:
1. create a account and go to detail view, user will get the Max resource count for the new resourcetypes along with the previously added resource types.
2. create a domain and go to detail view, admin will get the details of all the resourcestypes.
3. deploy a VM, resource count will update accordingly.
Thanks,
Sanjay Tripathi