[GitHub] [curator] eolivelli commented on a change in pull request #372: CURATOR-582: Migrate to jUnit 5.6

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #372:
URL: https://github.com/apache/curator/pull/372#discussion_r481087222



##########
File path: curator-client/src/test/java/org/apache/curator/BasicTests.java
##########
@@ -30,15 +37,13 @@
 import org.apache.zookeeper.ZooDefs;
 import org.apache.zookeeper.ZooKeeper;
 import org.mockito.Mockito;
-import org.testng.Assert;
-import org.testng.annotations.Test;
 import java.util.concurrent.Callable;
 import java.util.concurrent.CountDownLatch;
 import java.util.concurrent.atomic.AtomicBoolean;
 
 public class BasicTests extends BaseClassForTests
 {
-    @Test
+    @RepeatedIfExceptionsTest(repeats = BaseClassForTests.REPEATS)

Review comment:
       Personally (non binding) I would prefer to use the standard tools from the jUnit framework + surefire.
   So add a simply rerunFailingTests on surefire configuration is a better option.
   
   It would be better to not have flaky tests at all, but that would be a different story
   
   @Randgalt what's your opinion ?
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org